Skip to content

fix pre-commit errors #490

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
jameslamb wants to merge 3 commits into
base: main
Choose a base branch
from
Open

fix pre-commit errors #490

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
099793a
enforce pre-commit checks in CI
jameslamb Jan 14, 2026
3b6ef1e
remove workflow file
jameslamb Jan 14, 2026
7c07748
Merge branch 'main' into enforce-pre-commit
jameslamb Jan 16, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 9 additions & 3 deletions .github/actionlint.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,12 +1,18 @@
# Configuration related to self-hosted runners.
# Avoid warnings about unrecognized runner types.
self-hosted-runner:
# Labels of self-hosted runner in array of strings.
labels:
- linux-amd64-*
- linux-arm64-*

# Configuration variables in array of strings defined in your repository or organization.
# Avoid warnings about referencing things in ${{ vars.* }} statements.
config-variables:
- AWS_REGION
- AWS_ROLE_ARN
- TELEMETRY_ENABLED

paths:
.github/workflows/conda-python-tests.yaml:
ignore:
# ${{ secrets.CODECOV_TOKEN }} is valid if a secret like that exists in the calling repo,
# and we're confident that it's there in our repos, so this error can be silenced
- 'property "codecov_token" is not defined in object type'
2 changes: 1 addition & 1 deletion .github/workflows/conda-cpp-build.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -195,7 +195,7 @@ jobs:
GH_TOKEN: ${{ inputs.alternative-gh-token-secret-name && secrets[inputs.alternative-gh-token-secret-name] || github.token }} # zizmor: ignore[overprovisioned-secrets]
- name: C++ build
run: |
ulimit -n $(ulimit -Hn)
ulimit -n "$(ulimit -Hn)"
$INPUTS_SCRIPT
env:
INPUTS_SCRIPT: "${{ inputs.script }}"
Expand Down
3 changes: 1 addition & 2 deletions .github/workflows/conda-cpp-tests.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -282,7 +282,6 @@ jobs:
local val_str=$3
if test -n "${val_str}"; then
if ! test -n "${key_str}"; then
local input_name
echo "ERROR: '${input_prefix}-value' non-empty but '${input_prefix}-key' is empty. Set '${input_prefix}-key'."
exit 1
fi
Expand All @@ -294,7 +293,7 @@ jobs:
set_env_var '3' '${{ secrets.script-env-secret-3-key }}' '${{ secrets.script-env-secret-3-value }}'
- name: C++ tests
run: |
ulimit -n $(ulimit -Hn)
ulimit -n "$(ulimit -Hn)"
$INPUTS_SCRIPT
env:
INPUTS_SCRIPT: "${{ inputs.script }}"
Expand Down
2 changes: 1 addition & 1 deletion .github/workflows/conda-python-build.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -220,7 +220,7 @@ jobs:
- name: Python build
id: python-build
run: |
ulimit -n $(ulimit -Hn)
ulimit -n "$(ulimit -Hn)"
# shellcheck disable=SC1090
source "${INPUTS_SCRIPT}"

Expand Down
3 changes: 1 addition & 2 deletions .github/workflows/conda-python-tests.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -287,7 +287,6 @@ jobs:
local val_str=$3
if test -n "${val_str}"; then
if ! test -n "${key_str}"; then
local input_name
echo "ERROR: '${input_prefix}-value' non-empty but '${input_prefix}-key' is empty. Set '${input_prefix}-key'."
exit 1
fi
Expand All @@ -299,7 +298,7 @@ jobs:
set_env_var '3' '${{ secrets.script-env-secret-3-key }}' '${{ secrets.script-env-secret-3-value }}'
- name: Python tests
run: |
ulimit -n $(ulimit -Hn)
ulimit -n "$(ulimit -Hn)"
$INPUTS_SCRIPT
env:
INPUTS_SCRIPT: "${{ inputs.script }}"
Expand Down
2 changes: 1 addition & 1 deletion .github/workflows/custom-job.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -203,7 +203,7 @@ jobs:
persist-credentials: false
- name: Run script
run: |
ulimit -n $(ulimit -Hn)
ulimit -n "$(ulimit -Hn)"
$INPUTS_SCRIPT
env:
# NEEDS alternative-gh-token-secret-name - may require a token with more permissions
Expand Down
2 changes: 1 addition & 1 deletion .github/workflows/wheels-build.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -268,7 +268,7 @@ jobs:
- name: Build and repair the wheel
id: build-wheel
run: |
ulimit -n $(ulimit -Hn)
ulimit -n "$(ulimit -Hn)"
# shellcheck disable=SC1090
source "${INPUTS_SCRIPT}"

Expand Down
3 changes: 1 addition & 2 deletions .github/workflows/wheels-test.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -312,7 +312,6 @@ jobs:
local val_str=$3
if test -n "${val_str}"; then
if ! test -n "${key_str}"; then
local input_name
echo "ERROR: '${input_prefix}-value' non-empty but '${input_prefix}-key' is empty. Set '${input_prefix}-key'."
exit 1
fi
Expand All @@ -324,7 +323,7 @@ jobs:
set_env_var '3' '${{ secrets.script-env-secret-3-key }}' '${{ secrets.script-env-secret-3-value }}'
- name: Run tests
run: |
ulimit -n $(ulimit -Hn)
ulimit -n "$(ulimit -Hn)"
$INPUTS_SCRIPT
env:
INPUTS_SCRIPT: "${{ inputs.script }}"
Expand Down
2 changes: 0 additions & 2 deletions .pre-commit-config.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -26,10 +26,8 @@ repos:
hooks:
- id: verify-copyright
- repo: https://github.com/zizmorcore/zizmor-pre-commit
# Zizmor version.
rev: v1.20.0
hooks:
# Run the linter.
- id: zizmor
exclude: |
(?x)^(
Expand Down