Misiug/jinja docker compose #153
Open
+172
−34
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
misiugodfrey
commented
Dec 19, 2025
| @@ -0,0 +1,50 @@ | |||
| x-presto-native-worker-gpu: &gpu_worker_base | |||
Contributor
Author
There was a problem hiding this comment.
services starting with x- are considered "Extensions" and are ignored when bringing up services. This one is uses exclusively as an anchor.
Contributor
|
Do a clean build. Please delete all dockers images and perform multi-node images build and run once. Fix accordingly based on failures. IIUC, |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We want to be able to dynamically generate docker services for multiple workers that use separately assigned gpus.
This PR does so by replacing the docker-compose.native-gpu.yml file with a jinja template that gets expanded via python script when
start_native_gpu_presto.shis called based on the --num-workers (-w) parameter is called. If the option left unspecified, it continues to generate apresto-native-worker-gpuwith access to all gpus as normal.