Skip to content

Please consider the following formatting changes to #13241 #43

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
alibuild wants to merge 1 commit into from
Closed

Please consider the following formatting changes to #13241 #43

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 1 addition & 3 deletions PWGHF/HFL/TableProducer/electronSelectionWithTpcEmcal.cxx
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
// Copyright 2019-2020 CERN and copyright holders of ALICE O2.

Check failure on line 1 in PWGHF/HFL/TableProducer/electronSelectionWithTpcEmcal.cxx

View workflow job for this annotation

GitHub Actions / O2 linter

[pwghf/struct-member-order] 

Declare struct members in the conventional order. See the PWGHF coding guidelines.
// See https://alice-o2.web.cern.ch/copyright for details of the copyright holders.
// All rights not expressly granted are reserved.
//
Expand Down Expand Up @@ -71,7 +71,7 @@
KFParticle kfNonHfe;
Configurable<bool> fillEmcClusterInfo{"fillEmcClusterInfo", true, "Fill histograms with EMCal cluster info before and after track match"};
Configurable<bool> fillTrackInfo{"fillTrackInfo", true, "Fill histograms with Track Information info before track match"};
Configurable<int> emcalRegion{"emcalAcceptance", 0, "Select EMCal region for filling histograms"};

Check failure on line 74 in PWGHF/HFL/TableProducer/electronSelectionWithTpcEmcal.cxx

View workflow job for this annotation

GitHub Actions / O2 linter

[name/configurable] 

Use lowerCamelCase for names of configurables and use the same name for the struct member as for the JSON string. (Declare the type and names on the same line.)
// Event Selection
Configurable<float> zPvPosMax{"zPvPosMax", 10., "Maximum z of the primary vertex (cm)"};
Configurable<bool> isRun3{"isRun3", true, "Data is from Run3 or Run2"};
Expand Down Expand Up @@ -123,7 +123,7 @@
Configurable<int> pdgCodeBeautyMin{"pdgCodeBeautyMin", 4000, "Min beauty Hadron PdgCode"};
Configurable<int> pdgCodeBeautyMax{"pdgCodeBeautyMax", 6000, "Max beauty Hadron PdgCode"};

using TableCollisions = o2::soa::Filtered<o2::soa::Join<aod::Collisions, aod::Mults, aod::EvSels>>;

Check failure on line 126 in PWGHF/HFL/TableProducer/electronSelectionWithTpcEmcal.cxx

View workflow job for this annotation

GitHub Actions / O2 linter

[pwghf/struct-member-order] 

HfElectronSelectionWithTpcEmcal: using appears too early (before end of Configurable<).
using TableCollision = TableCollisions::iterator;
using TableTracks = o2::soa::Join<o2::aod::Tracks, o2::aod::TracksCov, o2::aod::TracksExtra, o2::aod::pidTPCFullEl, o2::aod::pidTOFFullEl, o2::aod::TracksDCA, o2::aod::TrackSelection, o2::aod::TrackSelectionExtension>;

Expand Down Expand Up @@ -384,7 +384,7 @@
int region = emcalRegion;
registry.fill(HIST("hNevents"), region)

registry.fill(HIST("hNevents"), 1);
registry.fill(HIST("hNevents"), 1);

// skip events with no clusters
if (emcClusters.size() == 0 && skipNoEmcClusters) {
Expand Down Expand Up @@ -580,11 +580,9 @@
if (std::abs(mother.pdgCode()) == kEtaLocal || std::abs(mother.pdgCode()) == kPi0 || std::abs(mother.pdgCode()) == kGamma) {
registry.fill(HIST("hMcgenAllNonHfeElectron"), particleMc.pt());


auto const& gmother = mother.mothers_first_as<aod::McParticles>();
// cases to consider: eta->e, eta->pi0->e, eta->gamma->e, eta->pi0->gamma->e, pi0->e, pi0->gamma->e


//================= eta->e ======================================
if (std::abs(mother.pdgCode()) == kEtaLocal) {

Expand Down
Loading