Skip to content

Venice warning fix#323

Open
DeStup wants to merge 1 commit intoravignir:masterfrom
DeStup:venice-fix-warning
Open

Venice warning fix#323
DeStup wants to merge 1 commit intoravignir:masterfrom
DeStup:venice-fix-warning

Conversation

@DeStup
Copy link
Contributor

@DeStup DeStup commented Oct 6, 2025

image i quess it's not necessary anymore? I received a caravan in technology without going over the limit

@SeventhM
Copy link
Collaborator

SeventhM commented Oct 7, 2025

Removing the unique entirely feels wrong. The cargo ship should always take up a a trade route, so removing the unique entirely is almost definitely wrong

What the warning is actually saying something which I missed previously: the conditional itself is wrong ("upon" discovering the tech only works for triggerables, which this is not. It should be "after" discovering the tech)

@DeStup
Copy link
Contributor Author

DeStup commented Oct 7, 2025

Removing the unique entirely feels wrong. The cargo ship should always take up a a trade route, so removing the unique entirely is almost definitely wrong

What the warning is actually saying something which I missed previously: the conditional itself is wrong ("upon" discovering the tech only works for triggerables, which this is not. It should be "after" discovering the tech)

i change to
"Provides [1] [Trade Route] <after discovering [Compass]>",
"Free [Cargo Ship] appears <upon discovering [Compass] technology>"
and look at this:

Unciv_w3rH58qCQ5

thats why i decided that it is not necessary. The caravan that appears does not require trade route.
At the same time, if you build normally in the city, it will consume trade route.

@SeventhM
Copy link
Collaborator

SeventhM commented Oct 7, 2025

That's... Uhhhhhhhhh....

Wait a sec, do you stay +1 trade route after passing the turn?

@DeStup
Copy link
Contributor Author

DeStup commented Oct 8, 2025

That's... Uhhhhhhhhh....

Wait a sec, do you stay +1 trade route after passing the turn?

yeah

Unciv_R17qew95NE

@SeventhM
Copy link
Collaborator

I'm doing all this checking and trying to debug, and I just realized I'm dumb

i change to
"Provides [1] [Trade Route] <after discovering [Compass]>",
"Free [Cargo Ship] appears <upon discovering [Compass] technology>"
and look at this:

Working as intended, please change this PR to that. The extra Trade Route you're seeing is not from Venice's UA, but from Compass itself

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants