Skip to content

Fix type missmatch for set_opts functions #41

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
vshakitskiy wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Fix type missmatch for set_opts functions #41

vshakitskiy wants to merge 2 commits into from

Conversation

@vshakitskiy
Copy link
Contributor

@vshakitskiy vshakitskiy commented Jan 12, 2026

@karlsson
Copy link

karlsson commented Jan 12, 2026

Since the reason type returned by Erlang for ssl:setopts is defines as just term() I guess this is the safest way to go. There is the type socket.SocketReason defined in glisten that seems to cover most reasons (einval for instance) but there is no guarantee it covers all there I think.
What you will lose now is how to see the fault that actually occurred.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@vshakitskiy @karlsson