Skip to content

Comments

PR #1119 Follow-up changes#1134

Closed
chrisxstyles wants to merge 1 commit intoray-project:masterfrom
chrisxstyles:pr_1119_follow_up
Closed

PR #1119 Follow-up changes#1134
chrisxstyles wants to merge 1 commit intoray-project:masterfrom
chrisxstyles:pr_1119_follow_up

Conversation

@chrisxstyles
Copy link
Contributor

@chrisxstyles chrisxstyles commented Jun 1, 2023

Why are these changes needed?

@kevin85421 - This PR addresses the comments left in PR #1119

Following up with the updates requested in this PR.

Checks

  • I've made sure the tests are passing.
  • Testing Strategy
    • Unit tests
    • Manual tests
    • This PR is not tested :(

@kevin85421
Copy link
Member

Close this PR in favor of #1271. Thank you for the PR.

@kevin85421 kevin85421 closed this Jul 26, 2023
@chrisxstyles chrisxstyles deleted the pr_1119_follow_up branch March 27, 2024 18:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants