cleanup: remove World#secondsToTicks and just pass tick values directly#6
Open
advnau wants to merge 2 commits intoraynna:mainfrom
Open
cleanup: remove World#secondsToTicks and just pass tick values directly#6advnau wants to merge 2 commits intoraynna:mainfrom
advnau wants to merge 2 commits intoraynna:mainfrom
Conversation
Fire enum had time in ticks. It was converting to ms and then back to ticks.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This looks to be a result of legacy behavior from the old slow executor used by matrix that was backed by a scheduled executor service.
If values were passed they were converted to be the equivalent values that would eventually be calculated.