HTML must be sanitized before parsing, to fixup any invalid characters #239
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Needle returns a buffer object when parse is equal to false, so adding properties, setting cookies its all an error, it must be terminated/returned early instead
Commit package-lock.json file, created by newer versions of npm.
Opts.parse = false always throws errors
Remove empty query string from base path when params are not passed.
I no longer have time available to fulfill these offers
Update needle dependancy
Allow get/post commands to accept params as contextCallback
Adds option to customise error codes + useragent as a function
fix rchipka#236, pagination preserves method
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
7 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See #238 for details