Makefile: Add _XOPEN_SOURCE macro for *BSD #40
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When building rirc on FreeBSD, I noticed some compiler warnings about a function called gettimeofday() is implicitly defined there. Even adding "sys/time.h" header, it seems like the function gettimeofday() is only visible, if __XSI_VISIBLE is defined (or simply _XOPEN_SOURCE). GNU systems, usually avoid such macros, with _GNU_SOURCE or _DEFAULT_SOURCE macro. *BSD needs this (at least _XOPEN_SOURCE >= 600) to use this function. Prototype definition: https://github.com/freebsd/freebsd-src/blob/13037eaabede7fb7fbc25f4e84b549c73f9acb3c/sys/sys/time.h#L631 Signed-off-by: rilysh <nightquick@proton.me>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When building rirc on FreeBSD, I noticed some compiler warnings about a function called gettimeofday() is implicitly defined there. Even adding "sys/time.h" header, it seems like the function gettimeofday() is only visible, if __XSI_VISIBLE is defined (or simply _XOPEN_SOURCE).
GNU systems, usually avoid such macros, with _GNU_SOURCE or _DEFAULT_SOURCE macro. *BSD needs this (at least _XOPEN_SOURCE >= 600) to use this function.
Prototype definition: https://github.com/freebsd/freebsd-src/blob/13037eaabede7fb7fbc25f4e84b549c73f9acb3c/sys/sys/time.h#L631