Skip to content

wifi_ctrl: fix null pointer dereference in bus_get_vap_init_parameter #749

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
svc-rdkeportal01 wants to merge 1 commit into
base: topic/coverity
Choose a base branch
from
Open

wifi_ctrl: fix null pointer dereference in bus_get_vap_init_parameter #749

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 6 additions & 3 deletions source/core/wifi_ctrl.c
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -608,6 +608,11 @@ bool check_for_greylisted_mac_filter(void)

void bus_get_vap_init_parameter(const char *name, unsigned int *ret_val)
{
if (name == NULL) {
wifi_util_error_print(WIFI_CTRL, "%s:%d: name is NULL\n", __func__, __LINE__);
return;
}

int rc = bus_error_success;
unsigned int total_slept = 0;
char *pTmp = NULL;
Expand Down Expand Up @@ -718,8 +723,7 @@ void bus_get_vap_init_parameter(const char *name, unsigned int *ret_val)
}

/* Ensure no corruption and name string is still valid */
if (name) {
get_bus_descriptor()->bus_data_free_fn(&data);
get_bus_descriptor()->bus_data_free_fn(&data);
}
}
wifi_util_dbg_print(WIFI_CTRL, "%s:%d bus_data_get_fn for %s: value:%d\n", __func__, __LINE__,
Expand Down Expand Up @@ -783,7 +787,6 @@ void start_gateway_vaps()
value = false;
// start public if tunnel is up
bus_get_vap_init_parameter(WIFI_DEVICE_TUNNEL_STATUS, &value);
if (value == true) {
set_wifi_public_vap_enable_status();
pub_svc->start_fn(pub_svc, WIFI_ALL_RADIO_INDICES, NULL);
}
Expand Down