wifi_ctrl: fix null pointer dereference in bus_get_vap_init_parameter#749
Open
svc-rdkeportal01 wants to merge 1 commit intotopic/coverityfrom
Open
wifi_ctrl: fix null pointer dereference in bus_get_vap_init_parameter#749svc-rdkeportal01 wants to merge 1 commit intotopic/coverityfrom
svc-rdkeportal01 wants to merge 1 commit intotopic/coverityfrom
Conversation
The bus_get_vap_init_parameter function was using the name parameter before checking if it was NULL, which could lead to segmentation faults. This commit adds a null check at the beginning of the function and returns early if the pointer is NULL, preventing the dereference from occurring. Changes: - Add null check for name parameter at function start - Return early with error logging if NULL - Remove redundant null check before bus_data_free_fn()
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR modifies the
bus_get_vap_init_parameterfunction insource/core/wifi_ctrl.cto add null check for the name parameter at the beginning of the function and return early to avoid segfaults.Changes Made
nameparameter at function startbus_data_free_fn()callTesting