Conversation
Reason for change: Add XF10 changes. Test Procedure: None Risks: None Priority: P0 Signed-off-by: Jonathan Wu <Jonathan_Wu@comcast.com>
Test Procedure: Resolve merge conflicts Priority:P2 Signed-off-by: vysakhav <vysakhav@protonmail.com>
There was a problem hiding this comment.
Pull request overview
This PR adds support for the XF10 product (model SCXF11BFL) by including the _SCXF11BFL_PRODUCT_REQ_ preprocessor macro and "SCXF11BFL" model number checks across the codebase. The changes enable the XF10 device to use the same configuration and behavior patterns as similar Sky Hub products like SCER11BEL.
Key changes:
- Added
_SCXF11BFL_PRODUCT_REQ_macro to conditional compilation blocks across C source files - Updated shell scripts to include "SCXF11BFL" model number checks
- Reordered some existing macro definitions for consistency (SR213 before WNXL11BWL)
Reviewed changes
Copilot reviewed 8 out of 8 changed files in this pull request and generated 4 comments.
Show a summary per file
| File | Description |
|---|---|
| source/webconfig/wifi_ovsdb_translator.c | Added XF10 macro to cloud VIF mapping and hostap management frame control conditionals |
| source/utils/wifi_util.c | Added XF10 macro to radio hardware type detection |
| source/dml/tr_181/ml/cosa_wifi_dml.c | Added XF10 macro to BCM platform include conditionals |
| source/db/wifi_db_apis.c | Added XF10 macro to WPA3 RFC, hostap frame control, and VAP configuration conditionals |
| source/db/wifi_db.c | Added XF10 macro to default VAP configuration for XHS disablement |
| source/core/wifi_ctrl.c | Added XF10 macro to Wi-Fi service initialization for credential validation |
| scripts/mesh_setip.sh | Added "SCXF11BFL" model checks for bridge utilities and mesh interface configuration |
| scripts/OneWiFi_Selfheal.sh | Added "SCXF11BFL" model checks for eco mode and radio status handling |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
|
|
||
| #if defined (_PP203X_PRODUCT_REQ_) || defined (_XER5_PRODUCT_REQ_) || defined (_XB10_PRODUCT_REQ_) || defined (_SCER11BEL_PRODUCT_REQ_) || defined (_GREXT02ACTS_PRODUCT_REQ_) || defined (_GREXT02ACTS_PRODUCT_REQ_) | ||
| #if defined (_PP203X_PRODUCT_REQ_) || defined (_XER5_PRODUCT_REQ_) || defined (_XB10_PRODUCT_REQ_) || \ | ||
| defined (_SCER11BEL_PRODUCT_REQ_) || defined (_GREXT02ACTS_PRODUCT_REQ_) || defined (_GREXT02ACTS_PRODUCT_REQ_) || \ |
There was a problem hiding this comment.
The macro _GREXT02ACTS_PRODUCT_REQ_ is defined twice in this preprocessor condition. Remove one of the duplicate occurrences.
| defined (_SCER11BEL_PRODUCT_REQ_) || defined (_GREXT02ACTS_PRODUCT_REQ_) || defined (_GREXT02ACTS_PRODUCT_REQ_) || \ | |
| defined (_SCER11BEL_PRODUCT_REQ_) || defined (_GREXT02ACTS_PRODUCT_REQ_) || \ |
| #endif // defined(_XB7_PRODUCT_REQ_) || defined(_XB8_PRODUCT_REQ_) || defined(_XB10_PRODUCT_REQ_) || | ||
| // defined(_SCER11BEL_PRODUCT_REQ_) || defined(_CBR2_PRODUCT_REQ_) || | ||
| // defined(_WNXL11BWL_PRODUCT_REQ_) || defined(_SR213_PRODUCT_REQ_) | ||
| // defined(_SR213_PRODUCT_REQ_) || \ defined(_WNXL11BWL_PRODUCT_REQ_) || defined(_SCXF11BFL_PRODUCT_REQ_) |
There was a problem hiding this comment.
The line continuation backslash is incorrectly placed in the middle of the comment instead of at the end of the line, and there's an extra space before "defined". The comment should have the backslash at the end of line 7299 if line continuation is needed, or remove it if the comment is meant to span multiple lines naturally.
| // defined(_SR213_PRODUCT_REQ_) || \ defined(_WNXL11BWL_PRODUCT_REQ_) || defined(_SCXF11BFL_PRODUCT_REQ_) | |
| // defined(_SR213_PRODUCT_REQ_) || defined(_WNXL11BWL_PRODUCT_REQ_) || defined(_SCXF11BFL_PRODUCT_REQ_) |
| eco_mode_2g=`dmcli eRT getv Device.WiFi.Radio.$radio_2g_instance.X_RDK_EcoPowerDown | grep "value:" | cut -f2- -d:| cut -f2- -d:` | ||
| eco_mode_6g="false" | ||
| elif [ "$MODEL_NUM" == "SCER11BEL" ] || [ "$MODEL_NUM" == "SCXF11BFL" ]; then | ||
| eco_mode_2g=`dmcli eRT getv Device.WiFi.Radio.$radio_2g_instance.X_RDK_EcoPowerDown | grep "value:" | cut -f2- -d:| cut -f2- -d:` |
There was a problem hiding this comment.
There is trailing whitespace at the end of this line. Remove the trailing space for consistency with coding standards.
| eco_mode_2g=`dmcli eRT getv Device.WiFi.Radio.$radio_2g_instance.X_RDK_EcoPowerDown | grep "value:" | cut -f2- -d:| cut -f2- -d:` | |
| eco_mode_2g=`dmcli eRT getv Device.WiFi.Radio.$radio_2g_instance.X_RDK_EcoPowerDown | grep "value:" | cut -f2- -d:| cut -f2- -d:` |
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
4 participants
Bringup PR - XF10-34 : Add XF10 support #526 into main branch.
Reason for change: Add XF10 changes.
Test Procedure: None
Risks: None
Priority: P2