RDKCOM-5492: RDKBDEV-3336 De-authenticating Hotspot Clients Upon DHCP Failure by rhegde114 · Pull Request #818 · rdkcentral/OneWifi

rhegde114 · 2026-01-06T18:49:58Z

Develop an event subscription handler in OneWifi to process the event received from hotspot component upon DHCP failure and initiated de-authentication of associated client

due to DHCP failure Changes: 1. Added Rbus event handler to moniter event from hotspot component in case of DHCP failure 2. push the event to queue to kick associated client when event is received

pradeeptakdas · 2026-01-15T18:32:47Z

Hi @rhegde114
Looks like the branch is out of date, Can you please rebase ?

rhegde114 · 2026-01-15T19:02:45Z

@pradeeptakdas , I have re-synced the branch.

mateuszCieslak-GL · 2026-01-29T00:53:33Z

source/core/wifi_ctrl.h

    bool                marker_list_config_subscribed;
    bool                wifi_sta_2g_status_subscribed;
    bool                wifi_sta_5g_status_subscribed;
+    bool                privateHotspotIPSubscribed;


stick to the naming convention

Suggested change

bool privateHotspotIPSubscribed;

bool private_hotspot_ip_subscribed;

mateuszCieslak-GL · 2026-01-29T01:10:06Z

source/core/wifi_ctrl_rbus_handlers.c

 }
 #endif

+static void handlePrivateHotspotClientDisconnect(char *event_name, raw_data_t *p_data, void *userData)


Please add a comment here how does the proper command should look like, and what its supposed to do i.e.
"// Hotspot app will use this to kick stations which won't complete DHCP in time.
// expected command from hotspot app:
// Device.X_COMCAST-COM_GRE.Hotspot.RejectAssociatedClient <mac>_<vap_index>"

Added comments before the handler

mateuszCieslak-GL · 2026-01-29T01:10:45Z

source/core/wifi_ctrl_rbus_handlers.c

+        return;
+
+    }
+    memset(tmp_str, 0, sizeof(tmp_str));


since youre already initializing other local variables to zero at the beginning of the function, it would make sense to do the same for tmp_str.

Fixed Review comment

mateuszCieslak-GL

please update

Pavlo-Uvarov · 2026-01-29T15:52:02Z

source/core/wifi_ctrl_rbus_handlers.c

        }
    }
 #endif
+    if(ctrl->privateHotspotIPSubscribed == false) {


Suggested change

if(ctrl->privateHotspotIPSubscribed == false) {

if(!ctrl->privateHotspotIPSubscribed) {

Pavlo-Uvarov · 2026-01-29T15:54:19Z

source/core/wifi_ctrl_rbus_handlers.c

+    if(ctrl->privateHotspotIPSubscribed == false) {
+        if (bus_desc->bus_event_subs_fn(&ctrl->handle, WIFI_PRIVATE_HOTSPOT_CLIENT_IP,handlePrivateHotspotClientDisconnect, NULL, 
+            0) != bus_error_success) {
+            wifi_util_info_print(WIFI_CTRL, "%s:%d bus: bus event:%s subscribe fail\n",


Suggested change

wifi_util_info_print(WIFI_CTRL, "%s:%d bus: bus event:%s subscribe fail\n",

wifi_util_error_print(WIFI_CTRL, "%s:%d bus: bus event:%s subscribe fail\n",

Pavlo-Uvarov · 2026-01-29T16:04:21Z

source/core/wifi_ctrl_rbus_handlers.c

+{
+    (void)userData;
+    char *pTmp = NULL;
+    char mac[64] = {0};


Why 64? Why not 18?

Fixed comment

Pavlo-Uvarov · 2026-01-29T16:16:26Z

source/core/wifi_ctrl_rbus_handlers.c

+        // Copy MAC (characters before '_')
+        size_t mac_len = tmp - pTmp;
+        strncpy(mac, pTmp, mac_len);
+        mac[mac_len] = '\0';


Suggested change

mac[mac_len] = '\0';

mac[sizeof(mac)] = '\0';

uchm this one would be dependent on chancing char mac[64] = {0}; to char mac[18], so might be safer to leave it as is - otherwise it will crash some strcpy down the line..

I am keeping the original changes as mac is declared as char Mac[18], so valid indices are 0 to 17. Writing to Mac[18] is undefined behavior (out of bounds).

My bad, you are correct. Just add -1, so that it would be sizeof(mac) - 1 and it should be fine.

Pavlo-Uvarov · 2026-01-29T16:24:22Z

source/core/wifi_ctrl_rbus_handlers.c

+    pTmp = (char *)p_data->raw_data.bytes;
+
+    if((strcmp(event_name, WIFI_PRIVATE_HOTSPOT_CLIENT_IP) != 0) || (pTmp == NULL)) {
+        wifi_util_info_print(WIFI_CTRL,"%s:%d Invalid event received,%s:%x\n", __func__, __LINE__, event_name, p_data->data_type);


Suggested change

wifi_util_info_print(WIFI_CTRL,"%s:%d Invalid event received,%s:%x\n", __func__, __LINE__, event_name, p_data->data_type);

wifi_util_error_print(WIFI_CTRL,"%s:%d Invalid event received,%s:%x\n", __func__, __LINE__, event_name, p_data->data_type);

Fixed review comment

due to DHCP failure Changes: 1. Added Rbus event handler to moniter event from hotspot component in case of DHCP failure 2. push the event to queue to kick associated client when event is received

mateuszCieslak-GL

look ok to me.

rhegde114 and others added 5 commits December 4, 2025 13:40

Description: Deauth hotspot client when client gets private ip address

f6ea8fc

due to DHCP failure Changes: 1. Added Rbus event handler to moniter event from hotspot component in case of DHCP failure 2. push the event to queue to kick associated client when event is received

Merge branch 'rdkcentral:develop' into develop

ca5f21c

Merge branch 'rdkcentral:develop' into develop

dce74a9

Description: Deauth hotspot client when client gets private ip address

2e12713

due to DHCP failure Changes: 1. Added Rbus event handler to moniter event from hotspot component in case of DHCP failure 2. push the event to queue to kick associated client when event is received

Merge branch 'rdkcentral:develop' into develop

7cd3b62

rhegde114 requested a review from a team as a code owner January 6, 2026 18:49

pradeeptakdas changed the title ~~RDKBDEV-3336:De-authenticating Hotspot Clients Upon DHCP Failure~~ RDKCOM-5492: RDKBDEV-3336 De-authenticating Hotspot Clients Upon DHCP Failure Jan 7, 2026

Merge branch 'rdkcentral:develop' into develop

f3a2943

Merge branch 'rdkcentral:develop' into develop

560fc84

mateuszCieslak-GL reviewed Jan 29, 2026

View reviewed changes

mateuszCieslak-GL suggested changes Jan 29, 2026

View reviewed changes

Pavlo-Uvarov reviewed Jan 29, 2026

View reviewed changes

rhegde114 added 5 commits January 29, 2026 10:40

Merge branch 'rdkcentral:develop' into develop

b835ef4

Description: Deauth hotspot client when client gets private ip address

3c5715f

due to DHCP failure Changes: 1. Added Rbus event handler to moniter event from hotspot component in case of DHCP failure 2. push the event to queue to kick associated client when event is received

Description: Deauth hotspot client when client gets private ip address

c5e778a

due to DHCP failure Changes: 1. Added Rbus event handler to moniter event from hotspot component in case of DHCP failure 2. push the event to queue to kick associated client when event is received

Merge branch 'rdkcentral:develop' into develop

a970652

Description: Deauth hotspot client when client gets private ip address

b506839

due to DHCP failure Changes: 1. Added Rbus event handler to moniter event from hotspot component in case of DHCP failure 2. push the event to queue to kick associated client when event is received

mateuszCieslak-GL approved these changes Feb 4, 2026

View reviewed changes

	bool privateHotspotIPSubscribed;
	bool private_hotspot_ip_subscribed;

	if(ctrl->privateHotspotIPSubscribed == false) {
	if(!ctrl->privateHotspotIPSubscribed) {

	wifi_util_info_print(WIFI_CTRL, "%s:%d bus: bus event:%s subscribe fail\n",
	wifi_util_error_print(WIFI_CTRL, "%s:%d bus: bus event:%s subscribe fail\n",

	wifi_util_info_print(WIFI_CTRL,"%s:%d Invalid event received,%s:%x\n", __func__, __LINE__, event_name, p_data->data_type);
	wifi_util_error_print(WIFI_CTRL,"%s:%d Invalid event received,%s:%x\n", __func__, __LINE__, event_name, p_data->data_type);

Conversation

rhegde114 commented Jan 6, 2026

Uh oh!

pradeeptakdas commented Jan 15, 2026

Uh oh!

rhegde114 commented Jan 15, 2026

Uh oh!

Choose a reason for hiding this comment

Uh oh!

mateuszCieslak-GL Jan 29, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

mateuszCieslak-GL left a comment

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

mateuszCieslak-GL left a comment

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

mateuszCieslak-GL Jan 29, 2026 •

edited

Loading