Skip to content

RDKB-62699: Add CSI interval parameter to JSON in consumer sample app #867

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
narendradandu wants to merge 2 commits into
base: develop
Choose a base branch
from
Open

RDKB-62699: Add CSI interval parameter to JSON in consumer sample app #867

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
a056a61
RDKB-62699:Add CSI interval parameter to JSON in consumer sample app
Aniket0606 Dec 4, 2025
a90a6da
Merge branch 'rdkcentral:develop' into csi_raw_hex_data
Aniket0606 Jan 29, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
22 changes: 22 additions & 0 deletions source/sampleapps/wifievents_consumer_sample.c
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -445,6 +445,25 @@ void client_csi_data_json_elem_add(cJSON *sta_obj, wifi_csi_data_t *csi,
json_add_wifi_csi_matrix_info(obj, csi);
}

int get_csi_data_interval(void)
{
if (g_csi_interval) {
return g_csi_interval;
} else {
return DEFAULT_CSI_INTERVAL;
}
}

void add_or_update_number(cJSON *obj, const char *key, double value)
{
cJSON *item = cJSON_GetObjectItem(obj, key);
if (item == NULL) {
cJSON_AddNumberToObject(obj, key, value);
} else {
item->valuedouble = value;
Copy link

Copilot AI Jan 29, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The add_or_update_number function directly modifies the valuedouble field of a cJSON item. While this works, it's safer to use the standard cJSON API pattern. Consider using cJSON_ReplaceItemInObject to replace the existing item with a new number object, which is the pattern consistently used throughout the codebase (see source/dml/tr_181/sbapi/cosa_wifi_apis.c:1664 and source/platform/common/data_model/wifi_dml_api.c:1815). Alternatively, if using a modern version of cJSON, use cJSON_SetNumberValue. Also note that when directly modifying valuedouble, you should also update valueint for consistency.

Suggested change
item->valuedouble = value;
#ifdef cJSON_SetNumberValue
cJSON_SetNumberValue(item, value);
#else
cJSON *new_item = cJSON_CreateNumber(value);
if (new_item != NULL)
{
cJSON_ReplaceItemInObject(obj, key, new_item);
}
#endif

Copilot uses AI. Check for mistakes.
}
}

void csi_data_in_json_format(mac_address_t sta_mac, wifi_csi_data_t *csi)
{
if (g_num_of_samples == -1) {
Expand All @@ -465,6 +484,9 @@ void csi_data_in_json_format(mac_address_t sta_mac, wifi_csi_data_t *csi)
cJSON_AddItemToObject(p_csi_json_obj->main_json_obj, "CSI", p_csi_json_obj->json_csi_obj);
}

add_or_update_number(p_csi_json_obj->json_csi_obj, "csi_sampling_interval_ms",
get_csi_data_interval());

if (p_csi_json_obj->json_sounding_devices == NULL) {
p_csi_json_obj->json_sounding_devices = cJSON_CreateArray();
VERIFY_NULL_CHECK(p_csi_json_obj->json_sounding_devices);
Expand Down
Loading