Skip to content

XB10-2061 Result string not available for preassoc and postassoc deny CAC cases#875

Merged
gsathish86 merged 4 commits intordkcentral:developfrom
skarth597:CAC
Feb 4, 2026
Merged

XB10-2061 Result string not available for preassoc and postassoc deny CAC cases#875
gsathish86 merged 4 commits intordkcentral:developfrom
skarth597:CAC

Conversation

@skarth597
Copy link
Contributor

Reason for change: To debug
Test Procedure:
1. Flash the build image
2. Run the CCI test case CAC0009
3. Check for the pre deny string in /rdklogs/logs/wifiConnAdmissionCtrl
Priority: P1
Risks: Low
Signed-off-by: Samyuktha Karthikeyan samyuktha_karthikeyan@comcast.com

… CAC cases

Reason for change: To debug
Test Procedure:
	1. Flash the build image
	2. Run the CCI test case CAC0009
	3. Check for the pre deny string in /rdklogs/logs/wifiConnAdmissionCtrl
Priority: P1
Risks: Low
Signed-off-by: Samyuktha Karthikeyan <samyuktha_karthikeyan@comcast.com>
… CAC cases

Reason for change: To debug
Test Procedure:
	1. Flash the build image
	2. Run the CCI test case CAC0009
	3. Check for the pre deny string in /rdklogs/logs/wifiConnAdmissionCtrl
Priority: P1
Risks: Low
Signed-off-by: Samyuktha Karthikeyan <samyuktha_karthikeyan@comcast.com>
@skarth597 skarth597 requested a review from a team as a code owner February 4, 2026 04:49
Copilot AI review requested due to automatic review settings February 4, 2026 04:49
Copy link

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Adds explicit webconfig state handling for the CAC (“connection_control”) subdoc so CAC status can be published back (bus publish/apply path) similarly to other subdocs, and narrows CAC apply behavior to hotspot VAPs.

Changes:

  • Introduces ctrl_webconfig_state_cac_cfg_rsp_pending and updates the pending-state analyzer to emit CAC status when pending.
  • Updates CAC apply logic to skip non-hotspot VAPs.
  • Updates webconfig_ctrl_apply() CAC handling to set/clear the CAC pending flag and to bus-apply the encoded CAC subdoc when appropriate.

Reviewed changes

Copilot reviewed 2 out of 3 changed files in this pull request and generated 2 comments.

File Description
source/core/wifi_ctrl_webconfig.c Adds CAC pending-state handling, skips CAC apply on non-hotspot VAPs, and enables CAC bus publish/apply flow.
source/core/wifi_ctrl.h Adds a CAC pending state bit and advances ctrl_webconfig_state_max.
source/core/services/vap_svc_public.c Whitespace/indentation-only adjustment around update_global_cache() call.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Comment on lines 1700 to 1705
unsigned int tgt_vap_index = l_vap_maps->vap_array[vap_index].vap_index;
if (!isVapHotspot(tgt_vap_index)) {
wifi_util_dbg_print(WIFI_CTRL,
"%s:%d Skipping cac config apply for non hotspot vap: %d \n", __func__,
__LINE__, vap_index);
continue;
Copy link

Copilot AI Feb 4, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The debug log is skipping/identifying VAPs using vap_index (array position), but the hotspot check is performed on tgt_vap_index (actual VAP index). This makes the log message misleading when troubleshooting CAC behavior. Log the actual VAP index (or vap_name) consistently (e.g., tgt_vap_index).

Copilot uses AI. Check for mistakes.
… CAC cases

Reason for change: To debug
Test Procedure:
	1. Flash the build image
	2. Run the CCI test case CAC0009
	3. Check for the pre deny string in /rdklogs/logs/wifiConnAdmissionCtrl
Priority: P1
Risks: Low
Signed-off-by: Samyuktha Karthikeyan <samyuktha_karthikeyan@comcast.com>
@gsathish86 gsathish86 merged commit 31bb8a6 into rdkcentral:develop Feb 4, 2026
7 checks passed
@github-actions github-actions bot locked and limited conversation to collaborators Feb 4, 2026
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants