CMFSUPPORT-2426 Add auto_pr_creation support for rdke manifests#24
CMFSUPPORT-2426 Add auto_pr_creation support for rdke manifests#24scthunderbolt merged 8 commits intodevelopfrom
Conversation
To support PR creation in middleware-manifest-rdke repo
…ifest script" This reverts commit 21e2ba0.
There was a problem hiding this comment.
Pull request overview
This PR adds support for automatically creating pull requests for rdke manifest updates when meta repository PRs are merged. The changes extend the existing manifest update automation to handle submanifest elements in addition to project elements.
Changes:
- Added new GitHub Actions workflow for rdke manifest auto-PR creation
- Extended XML update logic to process submanifest elements alongside project elements
- Added logging statements to improve debugging visibility
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 2 comments.
| File | Description |
|---|---|
| .github/workflows/auto_pr_creation_rdke_manifest.yml | New workflow file to automate PR creation for middleware-manifest-rdke repository |
| build_health_check_workflow_scripts/auto_pr_generation_manifest.py | Extended to support submanifest elements and added logging for better traceability |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
| required: true | ||
|
|
||
| jobs: | ||
| auto_pr_creation_rdkb_manifest: |
There was a problem hiding this comment.
The job name is 'auto_pr_creation_rdkb_manifest' but this file is for rdke manifests. The job name should be 'auto_pr_creation_rdke_manifest' to match the workflow filename and purpose.
| auto_pr_creation_rdkb_manifest: | |
| auto_pr_creation_rdke_manifest: |
| print("Checking submanifests {}".format(submanifest.get('project'))) | ||
| if submanifest.get('project') in updates and submanifest.get('revision') != updates[submanifest.get('project')]: | ||
| print("Updating {}: {} from {} to {}".format(xml_file, submanifest.get('project'), submanifest.get('revision'), updates[submanifest.get('project')])) |
There was a problem hiding this comment.
The logging format for submanifests uses 'project' attribute while the logging for projects uses 'name' attribute. For consistency, consider using the same attribute name or making it clear in the log message which attribute is being displayed. The submanifest element's primary identifier appears to be 'project', so the logging is accurate, but it differs from the pattern used for projects.
| print("Checking submanifests {}".format(submanifest.get('project'))) | |
| if submanifest.get('project') in updates and submanifest.get('revision') != updates[submanifest.get('project')]: | |
| print("Updating {}: {} from {} to {}".format(xml_file, submanifest.get('project'), submanifest.get('revision'), updates[submanifest.get('project')])) | |
| print("Checking submanifests (project={})".format(submanifest.get('project'))) | |
| if submanifest.get('project') in updates and submanifest.get('revision') != updates[submanifest.get('project')]: | |
| print("Updating {}: submanifest project {} from {} to {}".format(xml_file, submanifest.get('project'), submanifest.get('revision'), updates[submanifest.get('project')])) |
There was a problem hiding this comment.
Pull request overview
Copilot reviewed 2 out of 2 changed files in this pull request and generated no new comments.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Add auto_pr_creation_rdke_manifest yml file
Add submanifest support in auto_pr_generation_manifest script
plus adding more logging