Skip to content

CMFSUPPORT-2426 Add auto_pr_creation support for rdke manifests#24

Merged
scthunderbolt merged 8 commits intodevelopfrom
feature/CMFSUPPORT-2426
Jan 20, 2026
Merged

CMFSUPPORT-2426 Add auto_pr_creation support for rdke manifests#24
scthunderbolt merged 8 commits intodevelopfrom
feature/CMFSUPPORT-2426

Conversation

@scthunderbolt
Copy link
Contributor

Add auto_pr_creation_rdke_manifest yml file
Add submanifest support in auto_pr_generation_manifest script
plus adding more logging

@scthunderbolt scthunderbolt requested a review from a team as a code owner January 19, 2026 17:11
Copilot AI review requested due to automatic review settings January 19, 2026 17:11
Copy link

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR adds support for automatically creating pull requests for rdke manifest updates when meta repository PRs are merged. The changes extend the existing manifest update automation to handle submanifest elements in addition to project elements.

Changes:

  • Added new GitHub Actions workflow for rdke manifest auto-PR creation
  • Extended XML update logic to process submanifest elements alongside project elements
  • Added logging statements to improve debugging visibility

Reviewed changes

Copilot reviewed 2 out of 2 changed files in this pull request and generated 2 comments.

File Description
.github/workflows/auto_pr_creation_rdke_manifest.yml New workflow file to automate PR creation for middleware-manifest-rdke repository
build_health_check_workflow_scripts/auto_pr_generation_manifest.py Extended to support submanifest elements and added logging for better traceability

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

required: true

jobs:
auto_pr_creation_rdkb_manifest:
Copy link

Copilot AI Jan 19, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The job name is 'auto_pr_creation_rdkb_manifest' but this file is for rdke manifests. The job name should be 'auto_pr_creation_rdke_manifest' to match the workflow filename and purpose.

Suggested change
auto_pr_creation_rdkb_manifest:
auto_pr_creation_rdke_manifest:

Copilot uses AI. Check for mistakes.
Comment on lines +162 to +164
print("Checking submanifests {}".format(submanifest.get('project')))
if submanifest.get('project') in updates and submanifest.get('revision') != updates[submanifest.get('project')]:
print("Updating {}: {} from {} to {}".format(xml_file, submanifest.get('project'), submanifest.get('revision'), updates[submanifest.get('project')]))
Copy link

Copilot AI Jan 19, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The logging format for submanifests uses 'project' attribute while the logging for projects uses 'name' attribute. For consistency, consider using the same attribute name or making it clear in the log message which attribute is being displayed. The submanifest element's primary identifier appears to be 'project', so the logging is accurate, but it differs from the pattern used for projects.

Suggested change
print("Checking submanifests {}".format(submanifest.get('project')))
if submanifest.get('project') in updates and submanifest.get('revision') != updates[submanifest.get('project')]:
print("Updating {}: {} from {} to {}".format(xml_file, submanifest.get('project'), submanifest.get('revision'), updates[submanifest.get('project')]))
print("Checking submanifests (project={})".format(submanifest.get('project')))
if submanifest.get('project') in updates and submanifest.get('revision') != updates[submanifest.get('project')]:
print("Updating {}: submanifest project {} from {} to {}".format(xml_file, submanifest.get('project'), submanifest.get('revision'), updates[submanifest.get('project')]))

Copilot uses AI. Check for mistakes.
Copilot AI review requested due to automatic review settings January 20, 2026 14:14
Copy link

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Copilot reviewed 2 out of 2 changed files in this pull request and generated no new comments.


💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

@scthunderbolt scthunderbolt merged commit 21ddfe9 into develop Jan 20, 2026
12 of 13 checks passed
@github-actions github-actions bot locked and limited conversation to collaborators Jan 20, 2026
@scthunderbolt scthunderbolt deleted the feature/CMFSUPPORT-2426 branch January 20, 2026 14:22
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant