Skip to content

Set systemd 'SyslogIdentifier' parameter#65

Open
mcbridematt wants to merge 1 commit intordkcentral:developfrom
mcbridematt:develop
Open

Set systemd 'SyslogIdentifier' parameter#65
mcbridematt wants to merge 1 commit intordkcentral:developfrom
mcbridematt:develop

Conversation

@mcbridematt
Copy link

This patch has been part of meta-rdk-bsp-arm for a while and I believe it would be beneficial to upstream it.

A previous changeset made all services invoked via the "/bin/sh -c '(...)'" pattern, which causes all syslog/journalctl entries to have the sh process name.

This can cause a lot of confusion when viewing the system log via journalctl:

sh[5613]: Fetching values to form parodus command line arguments
sh[5151]: result =
sh[5151]: result = rdkb-generic-broadband-image_rdkb-2025q1-kirkstone_20250606001224
sh[5613]: Framing command for parodus
sh[5613]: Starting parodus with the following arguments
sh[5613]: ModelName=RPI  SerialNumber=  Manufacturer=Traverse  HW_MAC=00:0a:fa:24:29:5d ...
sh[5808]: rdk_dyn_log_initg_dl_socket = 3 __progname = parodus
sh[5551]: Conf file /etc/debug.ini open success
sh[5551]: rdk_dyn_log_initg_dl_socket = 3 __progname = CcspTandDSsp
sh[5551]: rdk_logger_init /etc/debug.ini Already Stack Level Logging processed... not processing again.
sh[5551]: ****LOADING DM LIBRARY***************
sh[5573]: CosaEthInferface initialization done!
sh[5573]: CcspHalExtSw_getAssociatedDevice not implemented on generic arm platforms yet

In the above output there is a mix of CcspPandMSsp, Parodus and CcspEthAgent, which is very confusing.

Setting the SyslogIdentifier in each systemd unit file allows the correct ident to be applied to the log entries:

PsmSsp[1820]: rdk_dyn_log_initg_dl_socket = 3 __progname = PsmSsp
CcspEthAgent[3754]: CcspHalExtSw_getAssociatedDevice not implemented on generic arm platforms yet

A previous changeset made all services invoked
via the "/bin/sh -c '(...)'" pattern, which causes all
syslog/journalctl entries to have the "sh" process name.

This can cause a lot of confusion when viewing the system log via journalctl:

rdkb-arm sh[5613]: Fetching values to form parodus command line arguments
rdkb-arm sh[5151]: result =
rdkb-arm sh[5151]: result = rdkb-generic-broadband-image_rdkb-2025q1-kirkstone_20250606001224
rdkb-arm sh[5613]: Framing command for parodus
rdkb-arm sh[5613]: Starting parodus with the following arguments
rdkb-arm sh[5613]: ModelName=RPI  SerialNumber=  Manufacturer=Traverse  HW_MAC=00:0a:fa:24:29:5d ...
rdkb-arm sh[5808]: rdk_dyn_log_initg_dl_socket = 3 __progname = parodus
rdkb-arm sh[5551]: Conf file /etc/debug.ini open success
rdkb-arm sh[5551]: rdk_dyn_log_initg_dl_socket = 3 __progname = CcspTandDSsp
rdkb-arm sh[5551]: rdk_logger_init /etc/debug.ini Already Stack Level Logging processed... not processing again.
rdkb-arm sh[5551]: ****LOADING DM LIBRARY***************
rdkb-arm sh[5573]: CosaEthInferface initialization done!
rdkb-arm sh[5573]: CcspHalExtSw_getAssociatedDevice not implemented on generic arm platforms yet

In the above output there is a mix of CcspPandMSsp, Parodus and CcspEthAgent, which
is very confusing.

Setting the SyslogIdentifier in each systemd unit file allows the correct
ident to be applied to the log entries:

PsmSsp[1820]: rdk_dyn_log_initg_dl_socket = 3 __progname = PsmSsp
CcspEthAgent[3754]: CcspHalExtSw_getAssociatedDevice not implemented on generic arm platforms yet
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

Status: Done

Development

Successfully merging this pull request may close these issues.

1 participant