Feature/dcm test

.github/workflows/L1-Test.yml

@@ -0,0 +1,28 @@
+name: Unit tests dcm-agent
+on:
+  pull_request:
+    branches: [ develop, main ]
+
+env:
+  AUTOMATICS_UNAME: ${{ secrets.AUTOMATICS_UNAME }}
+  AUTOMATICS_PASSCODE: ${{ secrets.AUTOMATICS_PASSCODE }}
+
+jobs:
+  execute-unit-tests-on-pr:
+    name: Execute unit tests in dcm-agent GTest suite
+    runs-on: ubuntu-latest
+    container:
+      image: ghcr.io/rdkcentral/docker-rdk-ci:latest
+
+    steps:
+      - name: Checkout code
+        uses: actions/checkout@v3
+
+      - name: Run unit tests
+        run: sh unit_test.sh
+
+      - name: Upload test results to automatic test result management system
+        if: github.repository_owner == 'rdkcentral'
+        run: |
+          git config --global --add safe.directory `pwd`
+          gtest-json-result-push.py /tmp/Gtest_Report https://rdkeorchestrationservice.apps.cloud.comcast.net/rdke_orchestration_api/push_unit_test_results `pwd`

.github/workflows/code-coverage.yml

@@ -0,0 +1,54 @@
+name: Code Coverage
+
+on:
+  pull_request:
+    branches: [ main, develop]
+
+jobs:
+  execute-unit-code-coverage-report-on-release:
+    name: Test coverage report for release
+    runs-on: ubuntu-latest
+    container:
+      image: ghcr.io/rdkcentral/docker-rdk-ci:latest
+
+    steps:
+      - name: Checkout code
+        uses: actions/checkout@v3
+
+      - name: Run unit tests with coverage flags enabled
+        run: |
+          sh unit_test.sh --enable-cov
+      - name: Caculate the code coverage summary
+        run: |
+          cd ./unittest
+          lcov --list coverage.info | grep "Lines\|Total" > /tmp/coverage_summary.txt
+          cd -
+
+      - name: Update the coverage report to Pull request using actions
+        uses: actions/github-script@v4
+        with:
+          script: |
+            const fs = require('fs');
+            const lcov_result = fs.readFileSync('/tmp/coverage_summary.txt', 'utf8'); 
+
+            github.issues.createComment({
+              issue_number: context.issue.number,
+              owner: context.repo.owner,
+              repo: context.repo.repo,
+              body: 
+                    '## Code Coverage Summary \n' +
+                    ' ' +
+                    '```' +
+                    lcov_result + 
+                    '```'
+            });
+      - name: Generate the html report
+        run: |
+          cd ./unittest
+          genhtml coverage.info --output-directory /tmp/coverage_report
+          cd -
+      - name: Upload the coverage report to Pull request using actions
+        uses: actions/upload-artifact@v4
+        with:
+          name: coverage-report
+          path: /tmp/coverage_report

cov_build.sh

@@ -52,5 +52,5 @@ sh  build_inside_container.sh
 
 
 cd $WORKDIR
-./configure --prefix=${INSTALL_DIR} CFLAGS="-DRDK_LOGGER -DHAS_MAINTENANCE_MANAGER -I$ROOT/iarmmgrs/maintenance/include"
+./configure --prefix=${INSTALL_DIR} CFLAGS="-DRDK_LOGGER -DHAS_MAINTENANCE_MANAGER -I$ROOT/iarmmgrs/maintenance/include -I/usr/local/include"
 make && make install

dcm.c

@@ -239,6 +239,7 @@ VOID dcmDaemonMainUnInit(DCMDHandle *pdcmHandle)
  *  @return  status.
  *  @retval  status.
  */
+#ifndef GTEST_ENABLE
 int main(int argc, char* argv[])
 {
     pid_t process_id       = 0;
@@ -386,3 +387,17 @@ int main(int argc, char* argv[])
     }
     return ret;
 }
+#endif
+
+#ifdef GTEST_ENABLE
+void get_dcmRunJobs(const INT8* profileName, VOID *pHandle) 
+{
+    dcmRunJobs(profileName, pHandle);
+}
+void get_sig_handler(INT32 sig)
+{
+     sig_handler(sig);	
+}
+#endif
+
+

dcm_cronparse.c

@@ -938,3 +938,30 @@ INT32 dcmCronParseExp(const INT8* expression, dcmCronExpr* target)
     return ret;
 }
 
+#ifdef GTEST_ENABLE
+INT32 (*getdcmCronParseToUpper(void)) (INT8*) 
+{
+	return &dcmCronParseToUpper;
+}
+UINT32 (*getdcmCronParseParseUint(void)) (const INT8*, INT32*) 
+{
+	return &dcmCronParseParseUint;
+}
+UINT32 (*getdcmCronParseNextSetBit(void)) (UINT8*, UINT32, UINT32, INT32*)
+{
+    return &dcmCronParseNextSetBit;
+}
+
+INT32 (*getdcmCronParseResetMin(void)) (struct tm*, INT32)
+{
+    return &dcmCronParseResetMin;
+}
+INT32 (*getdcmCronParseResetAllMin(void))(struct tm*, INT32*)
+{
+    return &dcmCronParseResetAllMin;
+}
+INT32 (*getdcmCronParseSetField(void))(struct tm*, INT32, INT32)
+{
+	return &dcmCronParseSetField;
+}
+#endif

dcm_cronparse.h

@@ -21,6 +21,11 @@
 
 #ifndef _DCM_CRONPARSE_H_
 #define _DCM_CRONPARSE_H_
+#include "dcm_types.h"
+#ifdef __cplusplus
+extern "C"
+{
+#endif
 
 /**
  * Parsed cron expression
@@ -38,6 +43,9 @@ INT32 dcmCronParseExp(const INT8* expression, dcmCronExpr* target);
 
 time_t dcmCronParseGetNext(dcmCronExpr* expr, time_t date);
 
+#ifdef __cplusplus
+}
+#endif
 #endif //_DCM_CRONPARSE_H_
 
 

dcm_parseconf.c

@@ -245,6 +245,7 @@ static INT32 dcmSettingStoreTempConf(INT8 *pConffile, INT8 *pTempConf, INT8 *pOp
     INT8 *buff     = NULL;
     INT32 i        = 0;
     INT32 ret      = DCM_SUCCESS;
+    FILE *fp_out_opt = NULL;
 
     FILE *fp_in = fopen(pConffile, "r");
     if (fp_in == NULL) {
@@ -259,7 +260,7 @@ static INT32 dcmSettingStoreTempConf(INT8 *pConffile, INT8 *pTempConf, INT8 *pOp
         goto exit1;
     }
 
-    FILE *fp_out_opt = fopen(pOptConf, "w");
+    fp_out_opt = fopen(pOptConf, "w");
     if (fp_out == NULL) {
         ret = DCM_FAILURE;
         DCMError("Unable to open out file: %s\n", pOptConf);
@@ -722,4 +723,5 @@ VOID dcmSettingsUnInit(VOID *pdcmSetHandle)
     }
     return dcmSettingStoreTempConf(defaultConfig, DCM_TMP_CONF, DCM_OPT_CONF);
  }
-
+
+

dcm_rbus.c

@@ -30,8 +30,9 @@
 #include <stdlib.h>
 #include <unistd.h>
 #include <signal.h>
-
+#ifndef GTEST_ENABLE
 #include "rbus.h"
+#endif
 #include "dcm_types.h"
 #include "dcm_rbus.h"
 #include "dcm_utils.h"
@@ -555,3 +556,25 @@ VOID dcmRbusUnInit (VOID *pDCMRbusHandle)
     free(plDCMRbusHandle);
 
 }
+
+#ifdef GTEST_ENABLE
+VOID get_rbusProcConf(rbusHandle_t handle, rbusEvent_t const* event, rbusEventSubscription_t* subscription)
+{
+     rbusProcConf(handle, event, subscription);
+}
+
+void get_rbusAsyncSubCB(rbusHandle_t handle, rbusEventSubscription_t* subscription, rbusError_t error)
+{
+     rbusAsyncSubCB(handle, subscription, error);
+}
+
+VOID get_rbusSetConf(rbusHandle_t handle, rbusEvent_t const* event, rbusEventSubscription_t* subscription)
+{
+     rbusSetConf(handle, event, subscription);
+}
+rbusError_t get_rbusSendEventCB(rbusHandle_t handle, rbusEventSubAction_t action, const INT8* eventName, rbusFilter_t filter, int32_t interval, BOOL* autoPublish)
+{
+     return rbusSendEventCB( handle, action, eventName, filter, interval, autoPublish);
+}
+#endif
+

dcm_utils.h

@@ -23,11 +23,15 @@
 #define _DCM_UTILS_H_
 
 #ifdef HAS_MAINTENANCE_MANAGER
+#ifndef GTEST_ENABLE
 #include "libIBus.h"
 #include "maintenanceMGR.h"
 #endif
+#endif
 
+#ifndef GTEST_ENABLE
 #include "rbus.h"
+#endif 
 
 #ifdef RDK_LOGGER_ENABLED
 #include "rdk_debug.h"
@@ -120,3 +124,5 @@ void DCMLOGInit();
 
 #endif //_DCM_UTILS_H
 
+
+

unit_test.sh

@@ -0,0 +1,103 @@
+#!/bin/bash
+
+#
+## Copyright 2023 Comcast Cable Communications Management, LLC
+##
+## Licensed under the Apache License, Version 2.0 (the "License");
+## you may not use this file except in compliance with the License.
+## You may obtain a copy of the License at
+##
+## http://www.apache.org/licenses/LICENSE-2.0
+##
+## Unless required by applicable law or agreed to in writing, software
+## distributed under the License is distributed on an "AS IS" BASIS,
+## WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+## See the License for the specific language governing permissions and
+## limitations under the License.
+##
+## SPDX-License-Identifier: Apache-2.0
+#
+
+ENABLE_COV=true
+
+if [ "x$1" = "x--enable-cov" ]; then
+      echo "Enabling coverage options"
+      export CXXFLAGS="-g -O0 -fprofile-arcs -ftest-coverage"
+      export CFLAGS="-g -O0 -fprofile-arcs -ftest-coverage"
+      export LDFLAGS="-lgcov --coverage"
+      ENABLE_COV=true
+fi
+export TOP_DIR=`pwd`
+export top_srcdir=`pwd`
+
+cd unittest/
+cp mocks/mockrbus.h /usr/local/include
+automake --add-missing
+autoreconf --install
+
+./configure
+
+make clean
+make
+
+fail=0
+
+for test in \
+  ./dcm_utils_gtest \
+  ./dcm_schedjob_gtest \
+  ./dcm_cronparse_gtest \
+  ./dcm_parseconf_gtest \
+  ./dcm_rbus_gtest \
+  ./dcm_gtest
+  #./rdm_main_gtest \
+  #./rdm_utils_gtest \
+  #./rdm_curl_gtest \
+  #./rdm_json_gtest \
+  #./rdm_download_gtest \
+  #./rdm_downloadutils_gtest \
+  #./rdm_rbus_gtest \
+  #./rdm_openssl_gtest \
+  #./rdm_usbinstall_gtest \
+
+do
+    $test
+    status=$?
+    if [ $status -ne 0 ]; then
+        echo "Test $test failed with exit code $status"
+        fail=1
+    fi
+done
+
+if [ $fail -ne 0 ]; then
+    echo "Some unit tests failed."
+    exit 1
+fi
+
+echo "********************"
+echo "**** CAPTURE DCM-AGENT COVERAGE DATA ****"
+echo "********************"
+if [ "$ENABLE_COV" = true ]; then
+    echo "Generating coverage report"
+    lcov --capture --directory . --output-file coverage.info
+    lcov --extract coverage.info "*/dcm*.c" -o newcov.info
+    lcov --list newcov.info
+    lcov --remove coverage.info '/usr/*' --output-file coverage.info
+    lcov --list coverage.info
+    lcov --remove coverage.info "${PWD}/*" --output-file coverage.info
+    lcov --list coverage.info
+fi
+
+#if [ "$ENABLE_COV" = true ]; then
+#    echo "Generating coverage report"
+#    lcov --capture --directory . --output-file coverage.info
+    #lcov --remove coverage.info "${PWD}/*" --output-file coverage.info
+    #lcov --remove coverage.info "$HOME/usr/*" --output-file coverage.info
+    #lcov --remove coverage.info "/usr/*" --output-file coverage.info
+#    lcov --extract coverage.info "*/dcm*.c" -o newcov.info
+#    lcov --list coverage.info
+#    lcov --list newcov.info
+#fi
+
+
+
+cd $TOP_DIR