Rebase #33

Saranya2421 · 2025-12-19T09:11:14Z

No description provided.

Clone iarmmgrs repository and update test list

.github/workflows/L1-Test.yml

+    name: Execute L1 test suite in test container environment
    runs-on: ubuntu-latest
-    container:
-      image: ghcr.io/rdkcentral/docker-rdk-ci:latest

    steps:
      - name: Checkout code
-        uses: actions/checkout@v3
+        uses: actions/checkout@v4
+
+      - name: Log in to GitHub Container Registry
+        uses: docker/login-action@v2
+        with:
+          registry: ghcr.io
+          username: ${{ github.actor }}
+          password: ${{ secrets.GITHUB_TOKEN }}
+
+      - name: Pull test container image
+        run: docker pull ghcr.io/rdkcentral/docker-device-mgt-service-test/native-platform:latest
+
+      - name: Start test container
+        run: |
+          docker run -d --name native-platform -v ${{ github.workspace }}:/mnt/L1_CONTAINER_SHARED_VOLUME ghcr.io/rdkcentral/docker-device-mgt-service-test/native-platform:latest

-      - name: Run unit tests
-        run: sh unit_test.sh
+      - name: Run L1 Unit Tests inside container
+        run: docker exec -i native-platform /bin/bash -c "cd /mnt/L1_CONTAINER_SHARED_VOLUME/ && sh unit_test.sh"

-      - name: Upload test results to automatic test result management system
+      - name: Copy L1 test results to runner
+        run: |
+          docker cp native-platform:/tmp/Gtest_Report /tmp/Gtest_Report
+          ls -l /tmp/Gtest_Report
+
+  upload-test-results:


In general, the fix is to explicitly define a permissions block either at the workflow level (root) or per job, restricting GITHUB_TOKEN to the minimal scope needed. That avoids inheriting potentially broad default repository permissions and follows the principle of least privilege.

For this workflow, the execute-L1-tests-on-pr job uses actions/checkout@v4, which requires contents: read. None of its steps write to the repo or perform other GitHub API mutations. The upload-test-results job does not interact with the GitHub API at all; it only reads local files and calls an external HTTP endpoint. Therefore:

At minimum, we should set permissions: contents: read for the workflow.

To be stricter, we can define permissions per job: execute-L1-tests-on-pr gets contents: read, and upload-test-results gets permissions: {} (no permissions), since it does not need GITHUB_TOKEN for any GitHub API calls.

To minimize functional impact while being explicit, we can add a workflow-level block with contents: read, which will apply to both jobs. This ensures actions/checkout still works and restricts any write permissions. The change should be added near the top of .github/workflows/L1-Test.yml, after name: and before on:. No additional imports or dependencies are required.

…ts To C Implementation (#35) * Created a comprehensive L2 test suite with 6 test modules covering error handling, normal uploads, retry logic, security, resource management, and upload strategies Updated build scripts and CI/CD workflow to compile with L2_TEST_ENABLED flag and execute the new test suite This feature file contains scenarios for normal log uploads, large log file handling, and MD5 checksum verification for the uploadSTBLogs service.

…ts To C Implementation (#49) * Simplify some pieces of code over engineered by AI models. * Update run_uploadstblogs_l2.sh for L2 coverage --------- Co-authored-by: Abhinav P V <Abhinav_Valappil@comcast.com>

…ts To C Implementation (#51) * Remove logging of response URLs * Apply suggestion from @Copilot Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com> --------- Co-authored-by: Shibu Kakkoth Vayalambron <shibu.kakkoth@gmail.com> Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>

Copilot

Pull request overview

This PR adds comprehensive unit test infrastructure for the uploadSTBLogs component through a rebase operation. The changes include Google Test-based unit tests for multiple modules, mock implementations, build configuration, and several new source files.

Changes:

Adds 18 comprehensive unit test files covering all major modules (verification, validation, upload engine, strategy handlers, archive manager, etc.)
Implements mock classes for RDK utilities, RBUS, CURL, and file operations
Adds build system configuration (Makefile.am, configure.ac)
Includes several new source implementation files (verification.c, validation.c, uploadstblogs.c, etc.)

Reviewed changes

Copilot reviewed 86 out of 87 changed files in this pull request and generated 66 comments.

Show a summary per file

File	Description
uploadstblogs/unittest/*_gtest.cpp	18 unit test files with comprehensive test coverage for different modules
uploadstblogs/unittest/mocks/*.h/.cpp	Mock implementations for external dependencies (RDK utils, RBUS, CURL, file operations)
uploadstblogs/unittest/Makefile.am	Build configuration for compiling and linking test executables
uploadstblogs/unittest/configure.ac	Autoconf configuration for test build system
uploadstblogs/src/*.c	New source implementation files (verification, validation, uploadstblogs, upload_engine, strategy_handler)
uploadstblogs/include/md5_utils.h	Header file for MD5 utility functions

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Copilot · 2026-01-13T18:18:49Z

uploadstblogs/unittest/strategy_handler_gtest.cpp

+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the Licesnse.


Corrected spelling of 'License' to 'Licesnse'

Copilot · 2026-01-13T18:18:50Z

uploadstblogs/unittest/verification_gtest.cpp

+const char* mock_curl_easy_strerror_impl(int curl_code) {
+    switch (curl_code) {
+        case 0: return "No error"; // CURLE_OK
+        case 7: return "Couldn't connect to server"; // CURLE_COULDNT_CONNECT  


Trailing whitespace at end of line 37 should be removed for code cleanliness.

Copilot · 2026-01-13T18:18:50Z

uploadstblogs/unittest/verification_gtest.cpp

+    EXPECT_FALSE(is_terminal_failure(403));
+}
+
+// Test is_curl_success function  


Trailing whitespace at end of line 144 should be removed for code cleanliness.

Copilot · 2026-01-13T18:18:50Z

test/functional-tests/tests/test_uploadstblogs_error_handling.py

+        result = run_uploadstblogs()
+
+        # Check for configuration error detection
+        error_logs = grep_uploadstb_logs_regex(r"ERROR|error|fail.*properties|invalid")


Variable error_logs is not used.

Suggested change

error_logs = grep_uploadstb_logs_regex(r"ERROR|error|fail.*properties|invalid")

error_logs = grep_uploadstb_logs_regex(r"ERROR|error|fail.*properties|invalid")

assert len(error_logs) > 0, f"Configuration error should be logged for corrupted properties, but found: {error_logs}"

Copilot · 2026-01-13T18:18:51Z

test/functional-tests/tests/test_uploadstblogs_error_handling.py

+
+        create_test_log_files(count=1)
+
+        result = run_uploadstblogs()


Variable result is not used.

Suggested change

result = run_uploadstblogs()

run_uploadstblogs()

Copilot · 2026-01-13T18:19:08Z

test/functional-tests/tests/uploadstblogs_helper.py

+import os
+import time
+import re
+import json


Import of 'json' is not used.

Copilot · 2026-01-13T18:19:08Z

test/functional-tests/tests/uploadstblogs_helper.py

+    try:
+        subprocess.run(f"echo '' > {UPLOADSTB_LOG}", shell=True)
+        return True
+    except:


Except block directly handles BaseException.

Copilot · 2026-01-13T18:19:09Z

test/functional-tests/tests/uploadstblogs_helper.py

+        if os.path.exists(LOCK_FILE):
+            os.remove(LOCK_FILE)
+        return True
+    except:


Except block directly handles BaseException.

Copilot · 2026-01-13T18:19:09Z

test/functional-tests/tests/uploadstblogs_helper.py

+            for chunk in iter(lambda: f.read(4096), b""):
+                md5_hash.update(chunk)
+        return md5_hash.hexdigest()
+    except:


Except block directly handles BaseException.

Copilot · 2026-01-13T18:19:09Z

test/functional-tests/tests/uploadstblogs_helper.py

+    """Get file size in bytes"""
+    try:
+        return os.path.getsize(filepath)
+    except:


Except block directly handles BaseException.

…ts To C Implementation (#54) * Update cov_build.sh to enable the rdkcertselector feature in the common_utilities build configuration to support the migration of operation support log upload scripts to C implementation. The change is part of resolving L2 test failures.

Copilot

Pull request overview

Copilot reviewed 86 out of 87 changed files in this pull request and generated 23 comments.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Copilot · 2026-01-21T19:06:42Z

test/functional-tests/tests/test_uploadstblogs_error_handling.py

+        result = run_uploadstblogs()
+
+        # Check for size limit detection
+        size_logs = grep_uploadstb_logs_regex(r"size.*limit|too large|exceed")


Variable size_logs is not used.

Suggested change

size_logs = grep_uploadstb_logs_regex(r"size.*limit|too large|exceed")

size_logs = grep_uploadstb_logs_regex(r"size.*limit|too large|exceed")

assert size_logs, "Expected size limit detection logs"

Copilot · 2026-01-21T19:06:42Z

test/functional-tests/tests/test_uploadstblogs_error_handling.py

+        result = run_uploadstblogs()
+
+        # Check for telemetry markers
+        telemetry_logs = grep_uploadstb_logs_regex(r"telemetry|marker|warning")


Variable telemetry_logs is not used.

Suggested change

telemetry_logs = grep_uploadstb_logs_regex(r"telemetry|marker|warning")

telemetry_logs = grep_uploadstb_logs_regex(r"telemetry|marker|warning")

# Ensure telemetry warning logs are present

assert telemetry_logs, "Expected telemetry warning logs to be present"

Copilot · 2026-01-21T19:06:43Z

test/functional-tests/tests/test_uploadstblogs_error_handling.py

+        result = run_uploadstblogs()
+
+        # Check for no files detection
+        no_files_logs = grep_uploadstb_logs_regex(r"no.*file|empty|not found|no logs")


Copilot · 2026-01-21T19:06:43Z

test/functional-tests/tests/test_uploadstblogs_error_handling.py

+        result = run_uploadstblogs()
+
+        # Check for informative message
+        logs = grep_uploadstb_logs_regex(r"no.*file|empty|nothing to upload")


Variable logs is not used.

Suggested change

logs = grep_uploadstb_logs_regex(r"no.*file|empty|nothing to upload")

logs = grep_uploadstb_logs_regex(r"no.*file|empty|nothing to upload")

assert logs, "Expected an informative 'no files' or 'empty logs' message in uploadSTBLogs logs"

Copilot · 2026-01-21T19:06:43Z

test/functional-tests/tests/test_uploadstblogs_error_handling.py

+
+        # Should not attempt upload
+        upload_logs = grep_uploadstb_logs_regex(r"upload.*success|uploading|HTTP")
+        # Might not see upload attempts


Variable upload_logs is not used.

Suggested change

# Might not see upload attempts

assert len(upload_logs) == 0, "Should not attempt upload when no log files exist"

Copilot · 2026-01-21T19:06:47Z

test/functional-tests/tests/test_uploadstblogs_upload_strategies.py

+        args = "'' 0 0 0 HTTP http://localhost:8080 0 0 ''"
+
+        result = run_uploadstblogs(args)
+


Variable result is not used.

Suggested change

# Ensure the upload process completes (0 or 1 are acceptable in other tests)

assert result.returncode in [0, 1], "DCM scheduled upload should complete"

Copilot · 2026-01-21T19:06:47Z

test/functional-tests/tests/test_uploadstblogs_upload_strategies.py

+        result = run_uploadstblogs(args)
+
+        # Check for log collection
+        collection_logs = grep_uploadstb_logs_regex(r"collect|archive|DCM")


Variable collection_logs is not used.

Suggested change

collection_logs = grep_uploadstb_logs_regex(r"collect|archive|DCM")

collection_logs = grep_uploadstb_logs_regex(r"collect|archive|DCM")

assert len(collection_logs) > 0, "DCM scheduled upload should collect or archive logs"

Copilot · 2026-01-21T19:06:48Z

test/functional-tests/tests/test_uploadstblogs_upload_strategies.py

+        result = run_uploadstblogs()
+
+        # Check for event publishing
+        event_logs = grep_uploadstb_logs_regex(r"event|publish|success")


Variable event_logs is not used.

Suggested change

event_logs = grep_uploadstb_logs_regex(r"event|publish|success")

_ = grep_uploadstb_logs_regex(r"event|publish|success")

Copilot · 2026-01-21T19:06:48Z

test/functional-tests/tests/test_uploadstblogs_upload_strategies.py

+
+        # Check for strategy selection
+        strategy_logs = grep_uploadstb_logs_regex(r"strategy|RRD|select")
+        assert result.returncode in [0, 1], "Should select appropriate strategy"


Variable strategy_logs is not used.

Suggested change

assert result.returncode in [0, 1], "Should select appropriate strategy"

assert result.returncode in [0, 1], "Should select appropriate strategy"

assert strategy_logs, "Expected strategy selection logs to be present"

Copilot · 2026-01-21T19:06:48Z

test/functional-tests/tests/test_uploadstblogs_error_handling.py

+
+import pytest
+import time
+from uploadstblogs_helper import *


Import pollutes the enclosing namespace, as the imported module uploadstblogs_helper does not define 'all'.

Suggested change

from uploadstblogs_helper import *

from uploadstblogs_helper import (

clear_uploadstb_logs,

remove_lock_file,

cleanup_test_log_files,

restore_device_properties,

kill_uploadstblogs,

create_test_log_files,

run_uploadstblogs,

grep_uploadstb_logs_regex,

DEVICE_PROPERTIES,

)

Valappil, Abhinav (Contractor) and others added 28 commits December 16, 2025 10:54

Logupload - script migration

1128aaf

Update context_manager.c

81a7e47

Update path_handler.c

c67d58a

Update path_handler.c

a9a2e33

Logupload migration

f0f0918

Update L1-Test.yml

4f0a608

Update unit_test.sh to include new tests

9b4d346

Clone iarmmgrs repository and update test list

Add files via upload

9fb8d96

Add files via upload

1ae54b6

Delete uploadstblogs/src/strategy_selector_gtest.cpp

e082b1d

Update strategy_selector_gtest.cpp

642a75d

Update strategy_selector_gtest.cpp

d2185c8

Update mock_curl.h

50d4d0b

Update mock_curl.cpp

599cc7a

Update mock_rdk_utils.h

2c09efb

Update archive_manager_gtest.cpp

5fdc686

Update cleanup_manager_gtest.cpp

6a508b9

Update context_manager_gtest.cpp

a52b7a1

Update event_manager_gtest.cpp

34c5372

Update log_collector_gtest.cpp

7abc8bb

Update md5_utils_gtest.cpp

e79c549

Update path_handler_gtest.cpp

f073ad9

Update rbus_interface_gtest.cpp

3b5a101

Delete uploadstblogs/unittest/run_retry_logic_test.sh

1b28d45

Update verification_gtest.cpp

4e70b3b

Update validation_gtest.cpp

d518bb3

Update uploadstblogs_gtest.cpp

157828c

Updating copyright header

6f493a6

Saranya2421 requested a review from a team as a code owner December 19, 2025 09:11

github-advanced-security bot found potential problems Dec 19, 2025

View reviewed changes

Abhinavpv28 and others added 3 commits January 6, 2026 14:12

RDK-57502 - [RDKE] Migrate Operation Support Log Upload Related Scrip…

ffd0993

…ts To C Implementation (#49) * Simplify some pieces of code over engineered by AI models. * Update run_uploadstblogs_l2.sh for L2 coverage --------- Co-authored-by: Abhinav P V <Abhinav_Valappil@comcast.com>

Copilot AI review requested due to automatic review settings January 13, 2026 18:09

Copilot started reviewing on behalf of shibu-kv January 13, 2026 18:09 View session

Copilot AI reviewed Jan 13, 2026

View reviewed changes

Abhinavpv28 added 2 commits January 14, 2026 08:57

Enable breakpad support for analyzing any crashes

d68ca8c

Copilot AI review requested due to automatic review settings January 21, 2026 18:58

Copilot started reviewing on behalf of shibu-kv January 21, 2026 18:59 View session

Changelog updates for 2.0.0 release

6e7c40d

Copilot AI reviewed Jan 21, 2026

View reviewed changes

Merge branch 'release/2.0.0' into develop

8696fdc

@@ -1,6 +1,9 @@
             name: L1 Unit Tests
+            permissions:
+              contents: read
             on:
               pull_request:
                 branches: [ develop, main ]

	error_logs = grep_uploadstb_logs_regex(r"ERROR\|error\|fail.*properties\|invalid")
	error_logs = grep_uploadstb_logs_regex(r"ERROR\|error\|fail.*properties\|invalid")
	assert len(error_logs) > 0, f"Configuration error should be logged for corrupted properties, but found: {error_logs}"

	size_logs = grep_uploadstb_logs_regex(r"size.*limit\|too large\|exceed")
	size_logs = grep_uploadstb_logs_regex(r"size.*limit\|too large\|exceed")
	assert size_logs, "Expected size limit detection logs"

	no_files_logs = grep_uploadstb_logs_regex(r"no.*file\|empty\|not found\|no logs")
	_ = grep_uploadstb_logs_regex(r"no.*file\|empty\|not found\|no logs")

	logs = grep_uploadstb_logs_regex(r"no.*file\|empty\|nothing to upload")
	logs = grep_uploadstb_logs_regex(r"no.*file\|empty\|nothing to upload")
	assert logs, "Expected an informative 'no files' or 'empty logs' message in uploadSTBLogs logs"

	# Might not see upload attempts
	assert len(upload_logs) == 0, "Should not attempt upload when no log files exist"

		args = "'' 0 0 0 HTTP http://localhost:8080 0 0 ''"

		result = run_uploadstblogs(args)



	# Ensure the upload process completes (0 or 1 are acceptable in other tests)
	assert result.returncode in [0, 1], "DCM scheduled upload should complete"

	collection_logs = grep_uploadstb_logs_regex(r"collect\|archive\|DCM")
	collection_logs = grep_uploadstb_logs_regex(r"collect\|archive\|DCM")
	assert len(collection_logs) > 0, "DCM scheduled upload should collect or archive logs"

	event_logs = grep_uploadstb_logs_regex(r"event\|publish\|success")
	_ = grep_uploadstb_logs_regex(r"event\|publish\|success")

	assert result.returncode in [0, 1], "Should select appropriate strategy"
	assert result.returncode in [0, 1], "Should select appropriate strategy"
	assert strategy_logs, "Expected strategy selection logs to be present"

-from uploadstblogs_helper import *
+from uploadstblogs_helper import (
+    clear_uploadstb_logs,
+    remove_lock_file,
+    cleanup_test_log_files,
+    restore_device_properties,
+    kill_uploadstblogs,
+    create_test_log_files,
+    run_uploadstblogs,
+    grep_uploadstb_logs_regex,
+    DEVICE_PROPERTIES,
+)

Rebase #33

Are you sure you want to change the base?

Rebase #33

Uh oh!

Conversation

Saranya2421 commented Dec 19, 2025

Uh oh!

Check warning

Copilot Autofix

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Reviewed changes

Uh oh!

Copilot AI Jan 13, 2026

Choose a reason for hiding this comment

Uh oh!

Copilot AI Jan 13, 2026

Choose a reason for hiding this comment

Uh oh!

Copilot AI Jan 13, 2026

Choose a reason for hiding this comment

Uh oh!

Copilot AI Jan 13, 2026

Choose a reason for hiding this comment

Uh oh!

Copilot AI Jan 13, 2026

Choose a reason for hiding this comment

Uh oh!

Copilot AI Jan 13, 2026

Choose a reason for hiding this comment

Uh oh!

Copilot AI Jan 13, 2026

Choose a reason for hiding this comment

Uh oh!

Copilot AI Jan 13, 2026

Choose a reason for hiding this comment

Uh oh!

Copilot AI Jan 13, 2026

Choose a reason for hiding this comment

Uh oh!

Copilot AI Jan 13, 2026

Choose a reason for hiding this comment

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Uh oh!

Copilot AI Jan 21, 2026

Choose a reason for hiding this comment

Uh oh!

Copilot AI Jan 21, 2026

Choose a reason for hiding this comment

Uh oh!

Copilot AI Jan 21, 2026

Choose a reason for hiding this comment

Uh oh!

Copilot AI Jan 21, 2026

Choose a reason for hiding this comment

Uh oh!

Copilot AI Jan 21, 2026

Choose a reason for hiding this comment

Uh oh!

Copilot AI Jan 21, 2026

Choose a reason for hiding this comment

Uh oh!

Copilot AI Jan 21, 2026

Choose a reason for hiding this comment

Uh oh!

Copilot AI Jan 21, 2026

Choose a reason for hiding this comment

Uh oh!

Copilot AI Jan 21, 2026

Choose a reason for hiding this comment

Uh oh!

Copilot AI Jan 21, 2026

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees