Skip to content

Conversation

Copy link

Copilot AI commented Jan 1, 2026

Commit 1ff07b3 refactored RuntimeContext from a flat structure to a nested structure with sub-objects (DeviceInfo, UploadSettings, etc.), but didn't update code accessing these fields, causing compilation failures.

Changes

  • context_manager.c: Updated field access patterns

    • ctx->mac_addressctx->device.mac_address
    • ctx->device_typectx->device.device_type
    • ctx->build_typectx->device.build_type
    • ctx->include_pcapctx->settings.include_pcap
  • strategies.c: Updated MAC and device type references in logging statements

  • archive_manager.c: Updated MAC address access in archive creation

  • strategy_handler.c: Updated context validation logging

Example

// Before (broken)
if (!get_mac_address(ctx->mac_address, sizeof(ctx->mac_address))) {
    return false;
}

// After (fixed)
if (!get_mac_address(ctx->device.mac_address, sizeof(ctx->device.mac_address))) {
    return false;
}

Note: Additional files (strategy_selector.c, event_manager.c, path_handler.c) still contain ctx->device_type references that need similar updates.


💬 We'd love your input! Share your thoughts on Copilot coding agent in our 2 minute survey.

Co-authored-by: Abhinavpv28 <162570454+Abhinavpv28@users.noreply.github.com>
Copilot AI changed the title [WIP] Fix RuntimeContext mac_address member issue Fix RuntimeContext field access after structure refactoring Jan 1, 2026
Copilot AI requested a review from Abhinavpv28 January 1, 2026 07:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants