Feature/simplifylib coverity file change #47

Abhinavpv28 · 2026-01-08T13:43:58Z

No description provided.

Copilot

Pull request overview

This pull request refactors the uploadstblogs codebase by simplifying the RuntimeContext structure and consolidating related functionality. The main changes flatten nested structures within RuntimeContext (removing paths, endpoints, flags, settings, device, and retry sub-structures) and merge related source files for better maintainability.

Key changes:

Flattened RuntimeContext structure by promoting nested fields to top-level members
Consolidated strategy implementations into a single strategies.c file (merging strategy_dcm.c, strategy_ondemand.c, strategy_reboot.c)
Merged log collection functionality into archive_manager.c (from log_collector.c)
Combined cleanup functionality into cleanup_handler.c (from cleanup_manager.c)
Added new uploadstblogs API functions (uploadstblogs_run, uploadstblogs_execute) with conditional binary compilation
Updated all test files to use the new flattened field access patterns
Modified build system (Makefile.am) to reflect file consolidations

Reviewed changes

Copilot reviewed 44 out of 45 changed files in this pull request and generated 4 comments.

Show a summary per file

File	Description
uploadstblogs/unittest/validation_gtest.cpp	Updated field access from ctx.paths.* to ctx.*
uploadstblogs/unittest/upload_engine_gtest.cpp	Updated field access patterns
uploadstblogs/unittest/strategy_selector_gtest.cpp	Updated field access from nested to flat structure
uploadstblogs/unittest/strategy_ondemand_gtest.cpp	File deleted, tests consolidated
uploadstblogs/unittest/strategy_handler_gtest.cpp	Updated field access patterns
uploadstblogs/unittest/strategy_dcm_gtest.cpp	File deleted, tests consolidated
uploadstblogs/unittest/strategies_gtest.cpp	New file with consolidated strategy tests
uploadstblogs/unittest/retry_logic_gtest.cpp	Updated ctx.retry.* to ctx.*
uploadstblogs/unittest/path_handler_gtest.cpp	Updated nested field access to flat, added HTTP result file handling
uploadstblogs/unittest/mocks/mock_file_operations.h	Added copy_file mock declaration
uploadstblogs/unittest/mocks/mock_file_operations.cpp	Added copy_file mock implementation
uploadstblogs/unittest/log_collector_gtest.cpp	Updated to use archive_manager.h with flattened structure
uploadstblogs/unittest/event_manager_gtest.cpp	Updated ctx.device.* to ctx.*
uploadstblogs/unittest/context_manager_gtest.cpp	Updated all nested field accesses
uploadstblogs/unittest/cleanup_handler_gtest.cpp	Updated includes and mock initialization
uploadstblogs/unittest/archive_manager_gtest.cpp	Added new log collection tests, updated field access
uploadstblogs/unittest/Makefile.am	Updated test executable names and removed obsolete tests
uploadstblogs/src/validation.c	Updated field access, added conditional PREV_LOG_PATH validation
uploadstblogs/src/uploadstblogs.c	Added new API functions, updated field access throughout
uploadstblogs/src/strategy_selector.c	Updated all field access patterns
uploadstblogs/src/strategy_reboot.c	File deleted, merged into strategies.c
uploadstblogs/src/strategy_ondemand.c	File deleted, merged into strategies.c
uploadstblogs/src/strategy_handler.c	Updated field access patterns
uploadstblogs/src/strategy_dcm.c	File deleted, merged into strategies.c
uploadstblogs/src/strategies.c	New consolidated file containing all three strategy implementations
uploadstblogs/src/retry_logic.c	Updated ctx.retry.* to ctx.*
uploadstblogs/src/path_handler.c	Updated field access, added HTTP result file routing for RRD vs standard uploads
uploadstblogs/src/log_collector.c	File deleted, merged into archive_manager.c
uploadstblogs/src/event_manager.c	Updated field access, added conditional maintenance events
uploadstblogs/src/context_manager.c	Updated all field initializations to flat structure
uploadstblogs/src/cleanup_manager.c	File deleted, merged into cleanup_handler.c
uploadstblogs/src/cleanup_handler.c	Merged cleanup_manager functionality, updated temp file cleanup
uploadstblogs/src/archive_manager.c	Merged log_collector functionality, updated field access

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Copilot · 2026-01-08T13:47:51Z

uploadstblogs/src/validation.c

+    if (ctx->rrd_flag == 0) {
    // Check PREV_LOG_PATH - critical for upload (matches script behavior)
-    if (strlen(ctx->paths.prev_log_path) > 0) {
-        if (!dir_exists(ctx->paths.prev_log_path)) {
-            RDK_LOG(RDK_LOG_ERROR, LOG_UPLOADSTB, "[%s:%d] The Previous Logs folder is missing: %s\n", 
-                    __FUNCTION__, __LINE__, ctx->paths.prev_log_path);
+        if (strlen(ctx->prev_log_path) > 0) {
+            if (!dir_exists(ctx->prev_log_path)) {
+                RDK_LOG(RDK_LOG_ERROR, LOG_UPLOADSTB, "[%s:%d] The Previous Logs folder is missing: %s\n", 
+                        __FUNCTION__, __LINE__, ctx->prev_log_path);
            // Script sends MAINT_LOGUPLOAD_ERROR=5 when PREV_LOG_PATH is missing
-            emit_folder_missing_error();
-            all_valid = false;
-        } else {
-            RDK_LOG(RDK_LOG_DEBUG, LOG_UPLOADSTB, "[%s:%d] PREV_LOG_PATH exists: %s\n", 
-                    __FUNCTION__, __LINE__, ctx->paths.prev_log_path);
+                emit_folder_missing_error();
+                all_valid = false;
+             } else {
+                RDK_LOG(RDK_LOG_DEBUG, LOG_UPLOADSTB, "[%s:%d] PREV_LOG_PATH exists: %s\n", 
+                        __FUNCTION__, __LINE__, ctx->prev_log_path);
+            }
        }
    }


The condition 'ctx->rrd_flag == 0' is added to check PREV_LOG_PATH validation. However, this logic change may affect RRD upload scenarios where PREV_LOG_PATH might still be needed. The original script behavior should be verified to ensure this conditional skipping of PREV_LOG_PATH validation for RRD uploads is correct.

Copilot · 2026-01-08T13:47:51Z

uploadstblogs/src/event_manager.c


    // Send maintenance event only if device is not broadband and maintenance enabled
-    if (!is_device_broadband(ctx) && is_maintenance_enabled()) {
+    if (!is_device_broadband(ctx) && is_maintenance_enabled() && ctx->rrd_flag == 0) {


The condition 'ctx->rrd_flag == 0' is added to emit_upload_success and emit_no_logs_reboot functions to conditionally send maintenance events. This changes the original behavior where maintenance events were sent regardless of rrd_flag. Verify that this is the intended behavior change and matches the script logic, as this could affect maintenance event reporting for RRD scenarios.

Suggested change

if (!is_device_broadband(ctx) && is_maintenance_enabled() && ctx->rrd_flag == 0) {

if (!is_device_broadband(ctx) && is_maintenance_enabled()) {

Copilot · 2026-01-08T13:47:52Z

uploadstblogs/unittest/path_handler_gtest.cpp

+int performMetadataPostWithCertRotationEx(const char *upload_url, const char *outfile,
                                          const char *extra_fields, MtlsAuth_t *sec_out,
                                          long *http_code_out);


The parameter name 'outfile' in the function signature should match the documentation and parameter description which refers to it as the output file for HTTP results. The parameter was previously named 'filepath' which was misleading. Consider updating the comment to clarify that this is now the output file path for storing HTTP results rather than the archive filepath.

Copilot · 2026-01-08T13:47:52Z

uploadstblogs/src/strategies.c

@@ -0,0 +1,1109 @@
+/*


The file starts with a UTF-8 BOM (Byte Order Mark) character sequence (). This can cause compilation issues with some C compilers and should be removed. The BOM is not needed for C source files and may lead to unexpected behavior.

Suggested change

/*

/*

Valappil, Abhinav (Contractor) and others added 30 commits December 28, 2025 09:14

Simplify strucrure variables

921c3b0

merge cleanup files

081f99c

update gtest file

909c3e0

Merge Logupload to archivemanager.c

ab6b48b

Fix L1

3bbb8c8

Merge strategy files

08d5b8b

L1 failure fix

6d4486e

L1 fix

36f077a

L1 fix

0327c36

L1 fix

24e4bfe

L1 fix

d4f5b40

L1 fix

fafcc8d

L1 fix

8f81a78

L1 fix

613652e

L1 fix

0ccd2e1

Li fix

3b8145c

Update uploadstblogs.h

ed3748f

Update uploadstblogs_types.h

1ff07b3

Update Makefile.am

8125970

Update uploadstblogs.c

1d95d5b

Update Makefile.am

06ae54e

Update uploadstblogs_types.h

bd3a6f4

Update uploadstblogs.c

7a4b88f

Update uploadstblogs_types.h

8692887

Update uploadstblogs.c

298a2ba

Update dcm_parseconf.c

9abcd73

Update dcm.c

69ad070

Remove unnecessary blank line in dcm.c

1c213a2

Update dcm_parseconf.c

32c367b

Update Makefile.am

b13e79c

Abhinavpv28 and others added 12 commits January 1, 2026 15:50

Update unit_test.sh

c834920

Update unit_test.sh

0b116fe

Update unit_test.sh

cb30982

Update validation.c

bbb0935

Update validation.c

cf78030

Update validation.c

1be01d7

Update event_manager.c

d0f1d53

Update dcm.c

254c3a3

Update dcm_parseconf.c

696bb6d

Update unit_test.sh

16f2a70

Update uploadstblogs.c

b12d01f

filechange

f63454e

Copilot AI review requested due to automatic review settings January 8, 2026 13:43

Abhinavpv28 requested a review from a team as a code owner January 8, 2026 13:43

Copilot started reviewing on behalf of Abhinavpv28 January 8, 2026 13:44 View session

Copilot AI reviewed Jan 8, 2026

View reviewed changes

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Feature/simplifylib coverity file change #47

Feature/simplifylib coverity file change #47

Uh oh!

Abhinavpv28 commented Jan 8, 2026

Uh oh!

Copilot AI left a comment

Uh oh!

Copilot AI Jan 8, 2026

Uh oh!

Copilot AI Jan 8, 2026

Uh oh!

Copilot AI Jan 8, 2026

Uh oh!

Copilot AI Jan 8, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

	if (!is_device_broadband(ctx) && is_maintenance_enabled() && ctx->rrd_flag == 0) {
	if (!is_device_broadband(ctx) && is_maintenance_enabled()) {

Feature/simplifylib coverity file change #47

Are you sure you want to change the base?

Feature/simplifylib coverity file change #47

Uh oh!

Conversation

Abhinavpv28 commented Jan 8, 2026

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Reviewed changes

Uh oh!

Copilot AI Jan 8, 2026

Choose a reason for hiding this comment

Uh oh!

Copilot AI Jan 8, 2026

Choose a reason for hiding this comment

Uh oh!

Copilot AI Jan 8, 2026

Choose a reason for hiding this comment

Uh oh!

Copilot AI Jan 8, 2026

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants