RDKB-60325 : notify_tunnel_status failure in hotspot by supriya-shree1 · Pull Request #5 · rdkcentral/hotspot

supriya-shree1 · 2025-08-12T08:59:04Z

Reason for change: notify_tunnel_status fails in hotspot
Test Procedure: TunnelStatus should get notified successfully
Risks: Low
Priority: P2

GoutamD2905 · 2025-08-25T13:16:27Z

Please write the L1 Unit Test cases for the New API and resolve the existing L1 test cases failures

supriya-shree1 · 2025-12-05T07:48:03Z

Bug Fix: TunnelStatus was not getting notified because the deprecated API CcspBaseIf_SendSignal_WithData was being used.
Change: Replaced it with rbusEvent_Publish in notify_tunnel_status to publish TunnelStatus via RBUS.
As part of this change:

Removed TunnelStatus parameter handling from PAM.
Registered TunnelStatus as an RBUS property/event in the Hotspot component.

Dependent PR: Provisioning and Management #149
[https://github.com/rdkcentral/provisioning-and-management/pull/149]
Validation: GTest results and validation logs are attached in Jira Ticket RDKB-60325.
[https://ccp.sys.comcast.net/browse/RDKB-60325]

CC: @snayak002c

Reason for change: notify_tunnel_status fails in hotspot Test Procedure: TunnelStatus should get notified Risks: Low Priority: P2

Reason for change: notify_tunnel_status fails in hotspot Test Procedure: TunnelStatus should get notified Risks: Low Priority: P2 Signed-off-by:SupriyaShree_SS@comcast.com

Reason for change: notify_tunnel_status fails in hotspot Test Procedure: TunnelStatus should get notified Risks: Low Priority: P2

Reason for change: notify_tunnel_status fails in hotspot Test Procedure: TunnelStatus should get notified Risks: Low Priority: P2 Signed-off-by:SupriyaShree_SS@comcast.com

source/test/HotspotFdTest/HotspotFdTest.cpp

rajkamal-cv · 2025-12-15T07:09:30Z

source/test/HotspotFdTest/HotspotFdTest.cpp

        }
 };

+extern char TunnelStatus[128];


TunnelStatus should be 8

Reason for change: notify_tunnel_status fails in hotspot Test Procedure: TunnelStatus should get notified successfully Risks: Low Priority: P2

apattu200 · 2025-12-30T14:59:00Z

source/hotspotfd/hotspotfd.c

@@ -2046,17 +2056,27 @@ void hotspot_start()
    hotspotfd_log();

 #ifdef WAN_FAILOVER_SUPPORTED


Device.X_COMCAST-COM_GRE.Tunnel.1.TunnelStatus , since it is under WAN_FAILOVER_SUPPORTED, hotspot behavior during down/up will break in CBR which doesn't have this CFLAG

This code change is expected to address the issue - 7176717

With code change ensured the Gerrit verification build passed for all devices - https://gerrit.teamccp.com/#/c/943504/

apattu200 · 2025-12-30T15:16:49Z

source/hotspotfd/hotspotfd.c

 #ifdef WAN_FAILOVER_SUPPORTED
-
+    rbusDataElement_t dataElements[1] = {
+        {"Device.X_COMCAST-COM_GRE.Tunnel.1.TunnelStatus", RBUS_ELEMENT_TYPE_EVENT | RBUS_ELEMENT_TYPE_PROPERTY, {TunnelStatus_GetStringHandler, TunnelStatus_SetStringHandler, NULL, NULL, NULL, NULL}}


Can you please confirm, rbus is not polling for ValueChange when someone subscribes for this parameter. since we have explicit publish this may not be needed.
In rbus code, i could see when element type is not property it won't go for autopublish, but want to double confirm

Otherwise we may need to have explicit subscribe handler with autoPublish setting to false

This code change is expected to address the issue - 4684824

A separate subscribe handler with autoPublish setting to false is implemented here

supriya-shree1 requested a review from a team as a code owner August 12, 2025 08:59

supriya-shree1 force-pushed the feature/update_rbus_send_data branch from 5d75f45 to 688a372 Compare August 14, 2025 05:25

sowmiyachelliah requested review from a team as code owners November 3, 2025 17:02

supriya-shree1 requested a review from snayak002c December 5, 2025 07:50

supriya-shree1 and others added 20 commits December 12, 2025 04:23

RDKB-60325 : notify_tunnel_status failure in hotspot

7804834

Reason for change: notify_tunnel_status fails in hotspot Test Procedure: TunnelStatus should get notified Risks: Low Priority: P2

RDKB-60325 : notify_tunnel_status failure in hotspot

158bc44

Reason for change: notify_tunnel_status fails in hotspot Test Procedure: TunnelStatus should get notified Risks: Low Priority: P2 Signed-off-by:SupriyaShree_SS@comcast.com

RDKB-60325 : notify_tunnel_status failure in hotspot

a04d5b3

Reason for change: notify_tunnel_status fails in hotspot Test Procedure: TunnelStatus should get notified Risks: Low Priority: P2 Signed-off-by:SupriyaShree_SS@comcast.com

RDKB-60325 : notify_tunnel_status failure in hotspot

4d97df7

Reason for change: notify_tunnel_status fails in hotspot Test Procedure: TunnelStatus should get notified Risks: Low Priority: P2 Signed-off-by:SupriyaShree_SS@comcast.com

RDKB-60325 : notify_tunnel_status failure in hotspot

d570fe3

Reason for change: notify_tunnel_status fails in hotspot Test Procedure: TunnelStatus should get notified Risks: Low Priority: P2 Signed-off-by:SupriyaShree_SS@comcast.com

RDKB-60325 : notify_tunnel_status failure in hotspot

abd3116

Reason for change: notify_tunnel_status fails in hotspot Test Procedure: TunnelStatus should get notified Risks: Low Priority: P2 Signed-off-by:SupriyaShree_SS@comcast.com

RDKB-60325 : notify_tunnel_status failure in hotspot

cf467f9

Reason for change: notify_tunnel_status fails in hotspot Test Procedure: TunnelStatus should get notified Risks: Low Priority: P2 Signed-off-by:SupriyaShree_SS@comcast.com

RDKB-60325 : notify_tunnel_status failure in hotspot

181ebd8

Reason for change: notify_tunnel_status fails in hotspot Test Procedure: TunnelStatus should get notified Risks: Low Priority: P2 Signed-off-by:SupriyaShree_SS@comcast.com

RDKB-60325 : notify_tunnel_status failure in hotspot

61731d5

Reason for change: notify_tunnel_status fails in hotspot Test Procedure: TunnelStatus should get notified Risks: Low Priority: P2 Signed-off-by:SupriyaShree_SS@comcast.com

RDKB-60325 : notify_tunnel_status failure in hotspot

2e2692a

Reason for change: notify_tunnel_status fails in hotspot Test Procedure: TunnelStatus should get notified Risks: Low Priority: P2 Signed-off-by:SupriyaShree_SS@comcast.com

RDKB-60325 : notify_tunnel_status failure in hotspot

7815fd8

Reason for change: notify_tunnel_status fails in hotspot Test Procedure: TunnelStatus should get notified Risks: Low Priority: P2 Signed-off-by:SupriyaShree_SS@comcast.com

RDKB-60325 : notify_tunnel_status failure in hotspot

365fada

Reason for change: notify_tunnel_status fails in hotspot Test Procedure: TunnelStatus should get notified Risks: Low Priority: P2 Signed-off-by:SupriyaShree_SS@comcast.com

RDKB-60325 : notify_tunnel_status failure in hotspot

9e0eac4

Reason for change: notify_tunnel_status fails in hotspot Test Procedure: TunnelStatus should get notified Risks: Low Priority: P2 Signed-off-by:SupriyaShree_SS@comcast.com

RDKB-60325 : notify_tunnel_status failure in hotspot

56e852c

Reason for change: notify_tunnel_status fails in hotspot Test Procedure: TunnelStatus should get notified Risks: Low Priority: P2 Signed-off-by:SupriyaShree_SS@comcast.com

RDKB-60325 : notify_tunnel_status failure in hotspot

de9ec24

Reason for change: notify_tunnel_status fails in hotspot Test Procedure: TunnelStatus should get notified Risks: Low Priority: P2 Signed-off-by:SupriyaShree_SS@comcast.com

RDKB-60325 : notify_tunnel_status failure in hotspot

26bfbe0

Reason for change: notify_tunnel_status fails in hotspot Test Procedure: TunnelStatus should get notified Risks: Low Priority: P2 Signed-off-by:SupriyaShree_SS@comcast.com

RDKB-60325 : notify_tunnel_status failure in hotspot

15da7bf

Reason for change: notify_tunnel_status fails in hotspot Test Procedure: TunnelStatus should get notified Risks: Low Priority: P2

RDKB-60325 : notify_tunnel_status failure in hotspot

aabc40f

Reason for change: notify_tunnel_status fails in hotspot Test Procedure: TunnelStatus should get notified Risks: Low Priority: P2 Signed-off-by:SupriyaShree_SS@comcast.com

RDKB-60325 : notify_tunnel_status failure in hotspot

2c504b6

Reason for change: notify_tunnel_status fails in hotspot Test Procedure: TunnelStatus should get notified Risks: Low Priority: P2 Signed-off-by:SupriyaShree_SS@comcast.com

RDKB-60325 : notify_tunnel_status failure in hotspot

d70236f

Reason for change: notify_tunnel_status fails in hotspot Test Procedure: TunnelStatus should get notified Risks: Low Priority: P2 Signed-off-by:SupriyaShree_SS@comcast.com

supriya-shree1 force-pushed the feature/update_rbus_send_data branch from e16e3ae to d70236f Compare December 12, 2025 10:58

github-advanced-security bot found potential problems Dec 12, 2025

View reviewed changes

supriya-shree1 mentioned this pull request Dec 15, 2025

RDKB-60325 : notify_tunnel_status failure in hotspot rdkcentral/provisioning-and-management#156

Merged

rajkamal-cv reviewed Dec 15, 2025

View reviewed changes

RDKB-60325 : notify_tunnel_status failure in hotspot

df2800f

Reason for change: notify_tunnel_status fails in hotspot Test Procedure: TunnelStatus should get notified successfully Risks: Low Priority: P2

supriya-shree1 requested a review from rajkamal-cv December 15, 2025 07:26

rajkamal-cv approved these changes Dec 15, 2025

View reviewed changes

apattu200 reviewed Dec 30, 2025

View reviewed changes

bunnam988 assigned snayak002c Jan 5, 2026

rajkamal-cv mentioned this pull request Jan 12, 2026

RDKB-60325 notify_tunnel_status failure in hotspot #33

Merged

		@@ -2046,17 +2056,27 @@ void hotspot_start()
		hotspotfd_log();

		#ifdef WAN_FAILOVER_SUPPORTED

Conversation

supriya-shree1 commented Aug 12, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

GoutamD2905 commented Aug 25, 2025

Uh oh!

supriya-shree1 commented Dec 5, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

rajkamal-cv Dec 15, 2025

Choose a reason for hiding this comment

Uh oh!

supriya-shree1 Dec 15, 2025

Choose a reason for hiding this comment

Uh oh!

apattu200 Dec 30, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

rajkamal-cv Jan 14, 2026

Choose a reason for hiding this comment

Uh oh!

apattu200 Dec 30, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

rajkamal-cv Jan 14, 2026

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

6 participants

supriya-shree1 commented Aug 12, 2025 •

edited

Loading

supriya-shree1 commented Dec 5, 2025 •

edited

Loading

apattu200 Dec 30, 2025 •

edited

Loading

apattu200 Dec 30, 2025 •

edited

Loading