RDKEAPPRT-434 : Resolve build failure in Application layer with the changes based on 8.4.1.0 MW release#162
Merged
ansu-mathew merged 2 commits intodevelopfrom Nov 19, 2025
Merged
Conversation
…hanges based on 8.4.1.0 MW release
There was a problem hiding this comment.
Pull Request Overview
This PR resolves a build failure by changing the mosquitto configuration approach from using a custom configuration file to modifying the default mosquitto.conf in-place using sed commands. The changes align the configuration management with the 8.4.1.0 middleware release requirements.
Key Changes
- Replaced custom mosquitto.conf file removal with in-place configuration modifications using sed
- Removed the custom mosquitto.conf file (904 lines) from dab-adapter package
- Removed mosquitto.conf installation logic from dab-adapter build recipe
Reviewed Changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated 4 comments.
| File | Description |
|---|---|
recipes-thirdparty/mosquitto/mosquitto_%.bbappend |
Modified to use sed commands for configuring allow_anonymous, user, and listener settings instead of removing the configuration file |
recipes-thirdparty/dab-adapter/files/mosquitto.conf |
Deleted custom mosquitto configuration file entirely |
recipes-thirdparty/dab-adapter/dab-adapter.inc |
Removed SRC_URI append, FILES variable, and installation commands for mosquitto.conf |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
lukiwa-metro
previously approved these changes
Nov 19, 2025
Contributor
lukiwa-metro
left a comment
lukiwa-metro
left a comment
There was a problem hiding this comment.
This approach looks good, have a look at the copilot remarks if any of those are applicable in our case.
lukiwa-metro
approved these changes
Nov 19, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.