keymapping: add descriptions for keymappings and OK button#166
keymapping: add descriptions for keymappings and OK button#166denisyuji wants to merge 1 commit intordkcentral:developfrom
Conversation
- Add mapping to the OK button - Added descriptions for new keymappings - Included details for YouTube button, Info overlay, Channel up, Channel down, Back, and OK/Select - Descriptions serve as inline documentation in the JSON
|
All contributors have signed the CLA ✍️ ✅ |
|
I have read the CLA Document and I hereby sign the CLA |
There was a problem hiding this comment.
Pull request overview
This PR enhances the keymapping configuration file by adding descriptive documentation for each keymapping entry and introduces a new mapping for the OK/Select button. The descriptions serve as inline documentation to make the JSON configuration more maintainable and understandable.
- Adds "description" fields to all existing keymappings (YouTube button, Info overlay, Channel up, Channel down, Back)
- Introduces a new keymapping entry for the OK/Select button (keycode 353 → 28)
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
| } | ||
| }, | ||
| { | ||
| "description": "OK/Select", |
There was a problem hiding this comment.
The description "OK/Select" uses a forward slash which is inconsistent with the other descriptions that use simple descriptive text. Consider using either "OK" or "Select" alone, or "OK button" to match the pattern used in "YouTube button".
| "description": "OK/Select", | |
| "description": "OK button", |
|
Hi @denisyuji , according to our current input event mapping definition, keycode 353 will not reach cobalt because it will be remapped here: |
2 participants
descriptionfield is ignored by the JSON parser but serve as inline documentation in the JSON