-
Notifications
You must be signed in to change notification settings - Fork 10
Topic/otel check #268
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
AravindanNC
wants to merge
7
commits into
develop
Choose a base branch
from
topic/otel-check
base: develop
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
+30
−0
Open
Topic/otel check #268
Changes from all commits
Commits
Show all changes
7 commits
Select commit
Hold shift + click to select a range
f0c3cd4
Update CMakeLists.txt
AravindanNC afcd7f1
Update CMakeLists.txt
AravindanNC f0c0203
Update LegacyWiFiManagerAPIs.cpp
AravindanNC d28533f
Update LegacyWiFiManagerAPIs.cpp
AravindanNC c0133b6
Update NetworkManagerRDKProxy.cpp
AravindanNC 70f7f93
Update NetworkManager.cpp
AravindanNC a0e9d91
Update CMakeLists.txt
AravindanNC File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,4 +1,4 @@ | ||
| /** | ||
|
Check failure on line 1 in plugin/NetworkManager.cpp
|
||
| * If not stated otherwise in this file or this component's LICENSE | ||
| * file the following copyright and licenses apply: | ||
| * | ||
|
|
@@ -18,6 +18,7 @@ | |
| **/ | ||
|
|
||
| #include "NetworkManager.h" | ||
| #include "rdk_otlp_instrumentation.h" | ||
| #include <random> | ||
|
|
||
| namespace WPEFramework | ||
|
|
@@ -67,6 +68,8 @@ | |
| // Syslog Startup messages are always printed by default | ||
| SYSLOG(Logging::Startup, (_T("Initializing NetworkManager"))); | ||
| NetworkManagerLogger::Init(); | ||
| // Initialize OpenTelemetry | ||
| rdk_otlp_init("NetworkManager", "1.0.0"); | ||
AravindanNC marked this conversation as resolved.
Show resolved
Hide resolved
|
||
| // Register the Connection::Notification first. Do this before we start our actual plugin | ||
| // in case something goes wrong or is disconnected - this way we know we're at least registered | ||
| // for activate/deactivate events | ||
|
|
||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -20,6 +20,7 @@ | |
| #include "NetworkManagerConnectivity.h" | ||
| #include "NetworkManagerRDKProxy.h" | ||
| #include "libIBus.h" | ||
| #include "rdk_otlp_instrumentation.h" | ||
| #include <chrono> | ||
|
|
||
| using namespace WPEFramework; | ||
|
|
@@ -33,7 +34,7 @@ | |
| { | ||
| namespace Plugin | ||
| { | ||
| NetworkManagerImplementation* _instance = nullptr; | ||
|
Check failure on line 37 in plugin/rdk/NetworkManagerRDKProxy.cpp
|
||
|
|
||
| Exchange::INetworkManager::WiFiState to_wifi_state(WiFiStatusCode_t code) { | ||
| switch (code) | ||
|
|
@@ -1157,6 +1158,9 @@ | |
| uint32_t NetworkManagerImplementation::GetConnectedSSID(WiFiSSIDInfo& ssidInfo /* @out */) | ||
| { | ||
| LOG_ENTRY_FUNCTION(); | ||
| NMLOG_INFO ("Before OTLP Trace start"); | ||
| rdk_otlp_start_distributed_trace("ConnectedSSID", "get"); | ||
AravindanNC marked this conversation as resolved.
Show resolved
Hide resolved
|
||
| NMLOG_INFO ("After OTLP Trace start"); | ||
AravindanNC marked this conversation as resolved.
Show resolved
Hide resolved
|
||
| uint32_t rc = Core::ERROR_RPC_CALL_FAILED; | ||
| IARM_Result_t retVal = IARM_RESULT_SUCCESS; | ||
| IARM_Bus_WiFiSrvMgr_Param_t param{}; | ||
|
|
@@ -1199,6 +1203,9 @@ | |
| { | ||
| NMLOG_ERROR ("GetConnectedSSID failed"); | ||
| } | ||
| NMLOG_INFO ("Before OTLP Trace end"); | ||
| rdk_otlp_finish_distributed_trace(); | ||
| NMLOG_INFO ("Before OTLP Trace end"); | ||
AravindanNC marked this conversation as resolved.
Show resolved
Hide resolved
|
||
| return rc; | ||
| } | ||
|
|
||
|
|
||
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.