Document 3-second blocking sleep in WPS disconnect flow

[Copilot]

Identified and documented synchronous sleep(3) blocking network thread during WPS operations in v1.13.0 changeset.

Location

File: plugin/gnome/NetworkManagerGnomeWIFI.cpp:1683
Function: wifiManager::wpsProcess()

nm_device_disconnect(wifidevice, NULL, &error);
if (error) {
    NMLOG_ERROR("disconnect connection failed %s", error->message);
    g_error_free(error);
}
sleep(3); // Blocks network thread for 3 seconds

Impact

• Single occurrence: 3-second blocking delay during WPS disconnect
• Worst case: 30 seconds cumulative (10 retry iterations × 3 seconds)
• Context: Triggered when WPS needs to disconnect existing connection before proceeding
• Blocking nature: Synchronous sleep freezes entire network thread

Documentation Added

• SLEEP_3SEC_DELAY.md - Detailed analysis of the 3-second sleep with code context, impact assessment, and async replacement recommendations
• NETWORK_DELAY_ANALYSIS.md - Complete v1.13.0 changeset analysis covering IPv4LL support, WiFi migration logic, and GCancellable implementation

Related Delays

Additional blocking operations identified in WPS flow:

• Line 1574: sleep(WPS_RETRY_WAIT_IN_MS) - 10-second retry delays
• Line 1913: g_usleep(500 * 1000) - 500ms delays

The sleep(3) should be replaced with async callback monitoring disconnect state changes rather than fixed-duration blocking.

---

✨ Let Copilot coding agent set things up for you — coding agent works faster and does higher quality work when set up for your repo.