-
Notifications
You must be signed in to change notification settings - Fork 4
Topic/rdksysintsw_3598 _rfc #146
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: develop
Are you sure you want to change the base?
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull request overview
This pull request adds conditional compilation directives to differentiate behavior between RDKB and non-RDKB platforms in the RFC (Runtime Feature Control) configuration handling code.
Changes:
- Wraps empty value validation in conditional compilation so it only applies to non-RDKB platforms
- Wraps account ID validation logic in conditional compilation so it only applies to non-RDKB platforms
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
| else | ||
| { | ||
|
|
||
| #if !defined(RDKB_SUPPORT) |
Copilot
AI
Jan 13, 2026
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Remove trailing whitespace/tabs at the end of this preprocessor directive line. Trailing whitespace can cause inconsistencies in code formatting and version control diffs.
| } | ||
|
|
||
| #endif | ||
|
|
Copilot
AI
Jan 13, 2026
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Remove this line containing only whitespace/tabs. Empty lines with whitespace can cause code formatting inconsistencies and should be replaced with a truly blank line.
| } | ||
| else | ||
| { | ||
| #if !defined(RDKB_SUPPORT) |
Copilot
AI
Jan 13, 2026
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Remove trailing whitespace/tabs at the end of this preprocessor directive line. Trailing whitespace can cause inconsistencies in code formatting and version control diffs.
No description provided.