RDKEMW-12168 Port the getAccountID Script functionality to RFC Module #148

madhubabutt · 2026-01-13T14:09:55Z

No description provided.

Copilot

Pull request overview

This pull request adds account ID validation functionality to the RFC module by porting the getAccountID script logic. The implementation validates that account IDs are exactly 32 characters long and contain only alphanumeric characters, hyphens, and underscores before accepting them.

Changes:

Added validate_account_id() function to validate account ID format
Added validation check in GetAccountID() to reject invalid account IDs
Defined KEY_LEN constant (32) for account ID length validation

Reviewed changes

Copilot reviewed 3 out of 3 changed files in this pull request and generated 8 comments.

File	Description
rfcMgr/rfc_common.cpp	Implements the validate_account_id function with regex-based validation for account ID format
rfcMgr/rfc_common.h	Declares the validate_account_id function and defines KEY_LEN constant
rfcMgr/rfc_xconf_handler.cpp	Integrates validation into GetAccountID() to reject invalid account IDs

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

rfcMgr/rfc_xconf_handler.cpp

Copilot · 2026-01-13T14:13:04Z

rfcMgr/rfc_xconf_handler.cpp

+            RDK_LOG(RDK_LOG_ERROR, LOG_RFCMGR, "[%s][%d] Invalid characters in newly received accountId: %s\n", __FUNCTION__, __LINE__,tempbuf);
+            _accountId="Unknown";


Inconsistent indentation. The code inside this else-if block uses extra indentation (12 spaces or 3 tabs) compared to the surrounding if-else blocks which use standard indentation (8 spaces or 2 tabs). This should match the indentation of lines 821-822 and 831-833.

Suggested change

RDK_LOG(RDK_LOG_ERROR, LOG_RFCMGR, "[%s][%d] Invalid characters in newly received accountId: %s\n", __FUNCTION__, __LINE__,tempbuf);

_accountId="Unknown";

RDK_LOG(RDK_LOG_ERROR, LOG_RFCMGR, "[%s][%d] Invalid characters in newly received accountId: %s\n", __FUNCTION__, __LINE__,tempbuf);

_accountId="Unknown";

Copilot · 2026-01-13T14:13:04Z

rfcMgr/rfc_xconf_handler.cpp

+    else if(!validate_account_id(tempbuf))
+    {
+            RDK_LOG(RDK_LOG_ERROR, LOG_RFCMGR, "[%s][%d] Invalid characters in newly received accountId: %s\n", __FUNCTION__, __LINE__,tempbuf);
+            _accountId="Unknown";


Missing space after assignment operator. Should be "_accountId = "Unknown";" instead of "_accountId="Unknown";" for consistency with the coding style used elsewhere in the codebase (see line 833).

Copilot · 2026-01-13T14:13:04Z

rfcMgr/rfc_xconf_handler.cpp

+    }
+    else if(!validate_account_id(tempbuf))
+    {
+            RDK_LOG(RDK_LOG_ERROR, LOG_RFCMGR, "[%s][%d] Invalid characters in newly received accountId: %s\n", __FUNCTION__, __LINE__,tempbuf);


The error message states "Invalid characters" but this validation also fails if the length is incorrect (not 32 characters). The error message should be more accurate, such as "Invalid accountId format (expected 32 alphanumeric characters, hyphens, or underscores)" to reflect both validation criteria.

Suggested change

RDK_LOG(RDK_LOG_ERROR, LOG_RFCMGR, "[%s][%d] Invalid characters in newly received accountId: %s\n", __FUNCTION__, __LINE__,tempbuf);

RDK_LOG(RDK_LOG_ERROR, LOG_RFCMGR, "[%s][%d] Invalid accountId format (expected 32 alphanumeric characters, hyphens, or underscores): %s\n", __FUNCTION__, __LINE__, tempbuf);

Copilot · 2026-01-13T14:13:05Z

rfcMgr/rfc_common.cpp

+bool validate_account_id(const std::string& accountId)
+{
+    static const std::regex has_valid("[a-zA-Z0-9_-]");
+    static const std::regex has_invalid("[!@#$%^&*()_+]");
+
+    // Must be exactly KEY_LEN
+    if (accountId.length() != KEY_LEN)
+        return false;
+
+    return std::regex_search(accountId, has_valid) &&
+           !std::regex_search(accountId, has_invalid);
+}


The new validation function validate_account_id lacks test coverage. Given that this function performs security-critical validation of account IDs and the repository has a gtest infrastructure in place (test/rfcTest.cpp), tests should be added to verify the function correctly validates valid account IDs and rejects invalid ones (wrong length, special characters, etc.).

Copilot · 2026-01-13T14:13:05Z

rfcMgr/rfc_common.cpp

+bool validate_account_id(const std::string& accountId)
+{
+    static const std::regex has_valid("[a-zA-Z0-9_-]");
+    static const std::regex has_invalid("[!@#$%^&*()_+]");
+
+    // Must be exactly KEY_LEN
+    if (accountId.length() != KEY_LEN)
+        return false;
+
+    return std::regex_search(accountId, has_valid) &&
+           !std::regex_search(accountId, has_invalid);
+}


Missing include directive for regex. The validate_account_id function uses std::regex and std::regex_search but the required header is not included in this file. This will cause compilation errors.

needed to ensure build failure

rfcMgr/rfc_common.cpp

nhanasi · 2026-01-13T16:07:57Z

@madhubabutt - please address commentds

Copilot

Pull request overview

Copilot reviewed 3 out of 3 changed files in this pull request and generated 5 comments.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

rfcMgr/rfc_common.cpp

rfcMgr/rfc_common.h

rfcMgr/rfc_xconf_handler.cpp

rdkcmf-jenkins · 2026-01-16T13:37:38Z

b'## Blackduck scan failure details

Summary: 0 violations, 0 files pending approval, 1 file pending identification.

Protex Server Path: /home/blackduck/github/rfc/148/rdk/components/generic/rfc
Commit: d66c9c7

Report detail: gist'

rdkcmf-jenkins · 2026-01-16T13:38:22Z

b'## Blackduck scan failure details

Summary: 0 violations, 0 files pending approval, 1 file pending identification.

Protex Server Path: /home/blackduck/github/rfc/148/rdk/components/generic/rfc
Commit: dad264c

Report detail: gist'

rdkcmf-jenkins · 2026-01-16T13:39:06Z

b'## Blackduck scan failure details

Summary: 0 violations, 0 files pending approval, 1 file pending identification.

Protex Server Path: /home/blackduck/github/rfc/148/rdk/components/generic/rfc
Commit: d69359c

Report detail: gist'

Copilot

Pull request overview

Copilot reviewed 2 out of 2 changed files in this pull request and generated 1 comment.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

rfcMgr/rfc_common.cpp

rdkcmf-jenkins · 2026-01-16T13:39:47Z

b'## Blackduck scan failure details

Summary: 0 violations, 0 files pending approval, 1 file pending identification.

Protex Server Path: /home/blackduck/github/rfc/148/rdk/components/generic/rfc
Commit: d69359c

Report detail: gist'

rfcMgr/rfc_xconf_handler.cpp

nhanasi · 2026-01-16T18:21:32Z

rfcMgr/rfc_common.cpp

    for (char c : str)
    {
-        if(!std::isalnum(c))
+        if(!std::isalnum(c) && c != '_' && c != '-')


we need length check and special char check also
similar to https://github.com/rdkcentral/sysint/blob/develop/lib/rdk/getAccountId.sh

Copilot

Pull request overview

Copilot reviewed 3 out of 3 changed files in this pull request and generated 5 comments.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

rfcMgr/rfc_xconf_handler.cpp

rfcMgr/rfc_common.cpp

rfcMgr/rfc_xconf_handler.cpp

rfcMgr/rfc_common.h

rfcMgr/rfc_common.cpp

Copilot

Pull request overview

Copilot reviewed 3 out of 3 changed files in this pull request and generated 4 comments.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

rfcMgr/rfc_xconf_handler.cpp

rfcMgr/rfc_common.cpp

Copilot

Pull request overview

Copilot reviewed 3 out of 3 changed files in this pull request and generated 2 comments.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

rfcMgr/rfc_common.cpp

rfcMgr/rfc_xconf_handler.cpp

Copilot

Pull request overview

Copilot reviewed 5 out of 5 changed files in this pull request and generated 5 comments.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

test/functional-tests/tests/test_rfc_invalid_accountid.py

run_l2.sh

test/functional-tests/tests/test_rfc_invalid_accoountid.py

test/functional-tests/tests/test_rfc_invalid_accountid.py

Copilot

Pull request overview

Copilot reviewed 5 out of 5 changed files in this pull request and generated 3 comments.

Comments suppressed due to low confidence (1)

run_l2.sh:57

The test_rfc_factory_reset.py test has been moved to run before test_rfc_trigger_reboot.py. If test execution order is significant (e.g., if tests share state or depend on specific sequences), ensure this reordering doesn't break the test suite.

pytest --json-report --json-report-summary --json-report-file $RESULT_DIR/rfc_factory_reset.json test/functional-tests/tests/test_rfc_factory_reset.py

pytest --json-report --json-report-summary --json-report-file $RESULT_DIR/rfc_trigger_reboot_unknown_accountid.json test/functional-tests/tests/test_rfc_trigger_reboot.py

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

rfcMgr/rfc_common.cpp

test/functional-tests/tests/test_rfc_invalid_accountid.py

Copilot

Pull request overview

Copilot reviewed 6 out of 6 changed files in this pull request and generated 1 comment.

Comments suppressed due to low confidence (1)

run_l2.sh:55

This line references test_rfc_factory_reset.py which doesn't exist in the repository. This will cause the test execution to fail. Either the test file needs to be added or this line should be removed.

pytest --json-report --json-report-summary --json-report-file $RESULT_DIR/rfc_factory_reset.json test/functional-tests/tests/test_rfc_factory_reset.py

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

test/functional-tests/tests/test_rfc_invalid_accountid.py

Copilot AI review requested due to automatic review settings January 13, 2026 14:09

madhubabutt requested a review from a team as a code owner January 13, 2026 14:09

Copilot started reviewing on behalf of madhubabutt January 13, 2026 14:10 View session

Copilot AI reviewed Jan 13, 2026

View reviewed changes

madhubabutt force-pushed the feature/RDKEMW-12168 branch from f9c53e8 to 55d2635 Compare January 13, 2026 14:35

Copilot AI review requested due to automatic review settings January 14, 2026 15:56

madhubabutt force-pushed the feature/RDKEMW-12168 branch from d2c3116 to 8d16195 Compare January 14, 2026 15:56

Copilot started reviewing on behalf of madhubabutt January 14, 2026 15:56 View session

Copilot AI reviewed Jan 14, 2026

View reviewed changes

madhubabutt force-pushed the feature/RDKEMW-12168 branch from 058913a to dd9417c Compare January 16, 2026 13:36

Copilot AI review requested due to automatic review settings January 16, 2026 13:37

madhubabutt force-pushed the feature/RDKEMW-12168 branch from d66c9c7 to dad264c Compare January 16, 2026 13:37

Copilot started reviewing on behalf of madhubabutt January 16, 2026 13:38 View session

Copilot AI reviewed Jan 16, 2026

View reviewed changes

rfcMgr/rfc_common.cpp Show resolved Hide resolved

nhanasi reviewed Jan 16, 2026

View reviewed changes

rfcMgr/rfc_xconf_handler.cpp Outdated Show resolved Hide resolved

nhanasi reviewed Jan 16, 2026

View reviewed changes

madhubabutt force-pushed the feature/RDKEMW-12168 branch from d69359c to 95380b8 Compare January 20, 2026 14:58

Copilot AI review requested due to automatic review settings January 20, 2026 15:02

madhubabutt force-pushed the feature/RDKEMW-12168 branch from 95380b8 to 94641a3 Compare January 20, 2026 15:02

Copilot started reviewing on behalf of madhubabutt January 20, 2026 15:02 View session

Copilot AI reviewed Jan 20, 2026

View reviewed changes

madhubabutt force-pushed the feature/RDKEMW-12168 branch from 94641a3 to 6bd602a Compare January 20, 2026 15:06

Copilot AI review requested due to automatic review settings January 20, 2026 15:10

madhubabutt force-pushed the feature/RDKEMW-12168 branch from 6bd602a to f44b897 Compare January 20, 2026 15:10

Copilot started reviewing on behalf of madhubabutt January 20, 2026 15:11 View session

madhubabutt force-pushed the feature/RDKEMW-12168 branch from f44b897 to 6aef810 Compare January 20, 2026 15:16

Copilot AI review requested due to automatic review settings January 20, 2026 15:21

madhubabutt force-pushed the feature/RDKEMW-12168 branch from 6aef810 to 10ff6f3 Compare January 20, 2026 15:21

Copilot started reviewing on behalf of madhubabutt January 20, 2026 15:22 View session

madhubabutt force-pushed the feature/RDKEMW-12168 branch from 10ff6f3 to fe6e424 Compare January 20, 2026 15:23

Copilot AI reviewed Jan 20, 2026

View reviewed changes

rfcMgr/rfc_xconf_handler.cpp Outdated Show resolved Hide resolved

rfcMgr/rfc_xconf_handler.cpp Outdated Show resolved Hide resolved

rfcMgr/rfc_common.cpp Outdated Show resolved Hide resolved

rfcMgr/rfc_common.cpp Outdated Show resolved Hide resolved

madhubabutt force-pushed the feature/RDKEMW-12168 branch from fe6e424 to 3988e3b Compare January 20, 2026 15:25

Copilot AI review requested due to automatic review settings January 20, 2026 15:40

madhubabutt force-pushed the feature/RDKEMW-12168 branch from 3988e3b to a6cdf31 Compare January 20, 2026 15:40

Copilot started reviewing on behalf of madhubabutt January 20, 2026 15:40 View session

Copilot AI reviewed Jan 20, 2026

View reviewed changes

rfcMgr/rfc_common.cpp Show resolved Hide resolved

rfcMgr/rfc_xconf_handler.cpp Show resolved Hide resolved

madhubabutt force-pushed the feature/RDKEMW-12168 branch from a6cdf31 to 1a39087 Compare January 22, 2026 12:05

Copilot AI review requested due to automatic review settings January 22, 2026 12:08

madhubabutt force-pushed the feature/RDKEMW-12168 branch from 1a39087 to 0cc8b3a Compare January 22, 2026 12:08

Copilot started reviewing on behalf of madhubabutt January 22, 2026 12:08 View session

madhubabutt force-pushed the feature/RDKEMW-12168 branch from 0cc8b3a to df1b46e Compare January 22, 2026 12:11

Copilot AI reviewed Jan 22, 2026

View reviewed changes

madhubabutt force-pushed the feature/RDKEMW-12168 branch from df1b46e to 6f54b92 Compare January 22, 2026 12:17

Copilot AI review requested due to automatic review settings January 22, 2026 12:20

madhubabutt force-pushed the feature/RDKEMW-12168 branch from 6f54b92 to 3b4c1d4 Compare January 22, 2026 12:20

Copilot started reviewing on behalf of madhubabutt January 22, 2026 12:20 View session

Copilot AI reviewed Jan 22, 2026

View reviewed changes

rfcMgr/rfc_common.cpp Show resolved Hide resolved

test/functional-tests/tests/test_rfc_invalid_accountid.py Outdated Show resolved Hide resolved

madhubabutt force-pushed the feature/RDKEMW-12168 branch from 9d7264f to 65d72e1 Compare January 22, 2026 12:25

Copilot AI review requested due to automatic review settings January 22, 2026 14:03

madhubabutt force-pushed the feature/RDKEMW-12168 branch from fcd79eb to a3d2502 Compare January 22, 2026 14:03

Copilot started reviewing on behalf of madhubabutt January 22, 2026 14:04 View session

Copilot AI reviewed Jan 22, 2026

View reviewed changes

test/functional-tests/tests/test_rfc_invalid_accountid.py Show resolved Hide resolved

RDKEMW-12168 Port the getAccountID Script functionality to RFC Module

fce09ac

madhubabutt force-pushed the feature/RDKEMW-12168 branch from 5900536 to fce09ac Compare January 26, 2026 06:34

Merge branch 'develop' into feature/RDKEMW-12168

8e29e4f

		RDK_LOG(RDK_LOG_ERROR, LOG_RFCMGR, "[%s][%d] Invalid characters in newly received accountId: %s\n", __FUNCTION__, __LINE__,tempbuf);
		_accountId="Unknown";

RDKEMW-12168 Port the getAccountID Script functionality to RFC Module #148

Are you sure you want to change the base?

RDKEMW-12168 Port the getAccountID Script functionality to RFC Module #148

Uh oh!

Conversation

madhubabutt commented Jan 13, 2026

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Reviewed changes

Uh oh!

Uh oh!

Copilot AI Jan 13, 2026

Choose a reason for hiding this comment

Uh oh!

Copilot AI Jan 13, 2026

Choose a reason for hiding this comment

Uh oh!

Copilot AI Jan 13, 2026

Choose a reason for hiding this comment

Uh oh!

Copilot AI Jan 13, 2026

Choose a reason for hiding this comment

Uh oh!

nhanasi Jan 13, 2026

Choose a reason for hiding this comment

Uh oh!

Copilot AI Jan 13, 2026

Choose a reason for hiding this comment

Uh oh!

nhanasi Jan 13, 2026

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

nhanasi commented Jan 13, 2026

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

rdkcmf-jenkins commented Jan 16, 2026

Uh oh!

rdkcmf-jenkins commented Jan 16, 2026

Uh oh!

rdkcmf-jenkins commented Jan 16, 2026

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Uh oh!

Uh oh!

rdkcmf-jenkins commented Jan 16, 2026

Uh oh!

Uh oh!

nhanasi Jan 16, 2026

Choose a reason for hiding this comment

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Uh oh!

Uh oh!

Uh oh!

Uh oh!