Skip to content

Conversation

Copy link

Copilot AI commented Jan 22, 2026

Addresses feedback from PR #143 regarding logging statements that became uninformative after std::move() operations.

Changes:

  • Removed std::move() from ClearDB and BootstrapClearDB parameters in set_RFCProperty() calls (lines 1298-1299)
  • Updated log statements to include actual key values instead of generic messages

Before:

set_RFCProperty(name, std::move(ClearDB), clearValue);
set_RFCProperty(name, std::move(BootstrapClearDB), clearValue);

RDK_LOG(RDK_LOG_INFO, LOG_RFCMGR, "[%s][%d] Clearing DB Value\n", __FUNCTION__,__LINE__);
RDK_LOG(RDK_LOG_INFO, LOG_RFCMGR, "[%s][%d] Bootstrap Clearing DB Value\n", __FUNCTION__,__LINE__);

After:

set_RFCProperty(name, ClearDB, clearValue);
set_RFCProperty(name, BootstrapClearDB, clearValue);

RDK_LOG(RDK_LOG_INFO, LOG_RFCMGR, "[%s][%d] Clearing DB Key Value: %s\n", __FUNCTION__,__LINE__,ClearDB.c_str());
RDK_LOG(RDK_LOG_INFO, LOG_RFCMGR, "[%s][%d] Bootstrap Clearing DB Key Value: %s\n", __FUNCTION__,__LINE__,BootstrapClearDB.c_str());

Move semantics provide minimal benefit for short-lived local string literals. Pattern now matches clearDBEnd() function.


💡 You can make Copilot smarter by setting up custom instructions, customizing its development environment and configuring Model Context Protocol (MCP) servers. Learn more Copilot coding agent tips in the docs.

Copilot AI and others added 3 commits January 22, 2026 13:17
Co-authored-by: Vismalskumar0 <188226757+Vismalskumar0@users.noreply.github.com>
Co-authored-by: Vismalskumar0 <188226757+Vismalskumar0@users.noreply.github.com>
Co-authored-by: Vismalskumar0 <188226757+Vismalskumar0@users.noreply.github.com>
Copilot AI changed the title [WIP] Address feedback on Coverity defect resolution for device management Remove std::move() and enhance logging in clearDB() Jan 22, 2026
Copilot AI requested a review from Vismalskumar0 January 22, 2026 13:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants