Skip to content

Conversation

Copy link

Copilot AI commented Jan 22, 2026

The feedback referenced in this PR about a use-after-move bug in ConfigChangeTime at line 1300 has already been addressed in commit 7206ff9.

Changes Already Applied

  • Line 1300: Removed std::move() from both ConfigChangeTimeKey and ConfigChangeTime parameters in set_RFCProperty() call
  • Line 1304: ConfigChangeTime.c_str() now safely accesses the variable without undefined behavior
// Before (use-after-move bug):
set_RFCProperty(name, std::move(ConfigChangeTimeKey), std::move(ConfigChangeTime));
// ... 
RDK_LOG(RDK_LOG_INFO, LOG_RFCMGR, "[%s][%d] ConfigChangeTime: %s\n", __FUNCTION__,__LINE__,ConfigChangeTime.c_str());

// After (fixed):
set_RFCProperty(name, ConfigChangeTimeKey, ConfigChangeTime);
// ...
RDK_LOG(RDK_LOG_INFO, LOG_RFCMGR, "[%s][%d] ConfigChangeTime: %s\n", __FUNCTION__,__LINE__,ConfigChangeTime.c_str());

Similar fixes were applied to ClearDBEndKey, BootstrapClearDBEndKey, and reloadCacheKey in the clearDBEnd() function in the same commit.


💬 We'd love your input! Share your thoughts on Copilot coding agent in our 2 minute survey.

Copilot AI changed the title [WIP] Address feedback on RDK Coverity defect resolution Confirm use-after-move fix for ConfigChangeTime is already applied Jan 22, 2026
Copilot AI requested a review from Vismalskumar0 January 22, 2026 13:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants