Rebase and merge #157
Open
Rebase and merge #157
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Disable the AccountID Special validation for RDKB
RDK-60308-[tr69hostif, RFC] RDK Coverity Defect Resolution for Device Management
Contributor
There was a problem hiding this comment.
Pull request overview
Adjusts RFC/XConf processing to apply certain validation and AccountID-handling logic only when RDKB_SUPPORT is not defined.
Changes:
- Wraps “reject empty config values” logic behind
#if !defined(RDKB_SUPPORT)inprocessXconfResponseConfigDataPart(). - Wraps the AccountID
"Unknown"special-case handling behind#if !defined(RDKB_SUPPORT)inisConfigValueChange().
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Comment on lines
+2416
to
+2422
| #if !defined(RDKB_SUPPORT) | ||
| if (newValue.empty()) | ||
| { | ||
| RDK_LOG(RDK_LOG_INFO, LOG_RFCMGR, "[%s][%d] EMPTY value for %s is rejected\n", __FUNCTION__, __LINE__, newKey.c_str()); | ||
| continue; | ||
| } | ||
| #endif |
There was a problem hiding this comment.
The empty-value rejection is now compiled out for RDKB_SUPPORT, but RDKB’s set_RFCProperty() converts non-string types using std::stoi/stoul/stof/etc without any exception handling. If XConf sends an empty string for a numeric/bool parameter, this will throw and can terminate the process. Consider keeping the empty-value guard for RDKB too (at least for non-string params) or adding safe parsing/try-catch with a logged failure + skip update.
Suggested change
| #if !defined(RDKB_SUPPORT) | |
| if (newValue.empty()) | |
| { | |
| RDK_LOG(RDK_LOG_INFO, LOG_RFCMGR, "[%s][%d] EMPTY value for %s is rejected\n", __FUNCTION__, __LINE__, newKey.c_str()); | |
| continue; | |
| } | |
| #endif | |
| if (newValue.empty()) | |
| { | |
| RDK_LOG(RDK_LOG_INFO, LOG_RFCMGR, "[%s][%d] EMPTY value for %s is rejected\n", __FUNCTION__, __LINE__, newKey.c_str()); | |
| continue; | |
| } |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.