-
Notifications
You must be signed in to change notification settings - Fork 4
RDK-60308 [tr69hostif, RFC] RDK Coverity Defect Resolution for Device #162
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: develop
Are you sure you want to change the base?
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull request overview
This PR modernizes C++ string initialization and improves code quality in the RFC (Runtime Feature Control) handler by converting copy initialization to direct initialization and adding proper control flow in a switch statement.
Changes:
- Updated string variable initializations from copy initialization (
std::string var = "value") to direct initialization (std::string var("value")) across multiple functions - Added missing
breakstatements and adefaultcase to the curl error code switch statement for proper control flow - Optimized string assignments by using
std::move()semantics for accountId and partnerId to avoid unnecessary copies
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull request overview
Copilot reviewed 1 out of 1 changed files in this pull request and generated 2 comments.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull request overview
Copilot reviewed 1 out of 1 changed files in this pull request and generated 1 comment.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull request overview
Copilot reviewed 1 out of 1 changed files in this pull request and generated no new comments.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
|
Please share the Dev Test results for RDKV and RDKB |
RDK-60308 [tr69hostif, RFC] RDK Coverity Defect Resolution for Device
Reason for change :Resolved the coverity issues reported by Cov scans.