gh13 finish shouldn't update manifest #15
Conversation
There was a problem hiding this comment.
Pull request overview
This PR removes manifest update functionality from the finish command, ensuring that the manifest file is only updated during the push command rather than during the finish operation. This aligns with the principle that finish should only perform merges, while push handles manifest updates and remote synchronization.
Key Changes:
- Removed
_update_manifest_revisionsmethod and its calls from the finish command - Cleaned up trailing whitespace and formatting inconsistencies throughout the file
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
| Repo(self.top_dir / '.repo' / 'manifests').git.switch(base) | ||
| manifest = ScManifest.from_repo_root(self.top_dir / '.repo') | ||
| for proj in manifest.projects: | ||
| if proj.lock_status == None: |
There was a problem hiding this comment.
Inconsistent None comparison style. Line 238 uses == None while lines 220 and 229 have similar comparisons. For consistency and Python best practices, all None comparisons should use is None or is not None.
| Repo(self.top_dir / '.repo' / 'manifests').git.switch('master') | ||
| manifest = ScManifest.from_repo_root(self.top_dir / '.repo') | ||
| for proj in manifest.projects: | ||
| if proj.lock_status == None: |
There was a problem hiding this comment.
Inconsistent None comparison style. Line 229 uses == None while lines 220 and 238 use is None. For consistency and Python best practices, all None comparisons should use is None or is not None.
Closes #13
Finish shouldn't update the manifest only merge. Push should be what updates the manifest.