gh18 don't prepend branch prefix if provided #21
Conversation
There was a problem hiding this comment.
Pull request overview
This pull request addresses issue #18 by improving branch handling and initialization behavior. The changes prevent duplicate gitflow initialization and add support for users to provide branch names with their type prefix (e.g., "feature/my-branch") which will be automatically stripped.
Key Changes:
- Added guard to prevent re-initialization of gitflow when already enabled
- Implemented automatic stripping of branch type prefix from user-provided branch names
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| src/sc/branching/commands/init.py | Adds check to prevent gitflow re-initialization if already enabled |
| src/sc/branching/branching.py | Strips branch type prefix from provided names for better UX |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
| if name.startswith(f"{branch_type}/"): | ||
| name = name.split("/", 1)[1] |
There was a problem hiding this comment.
The branch prefix stripping logic doesn't handle the edge case where the provided name is just the prefix with a trailing slash (e.g., "feature/"). This would result in an empty string being passed to the Branch constructor, which will fail with a ValueError. Consider adding validation to check if the remaining name after stripping the prefix is non-empty before proceeding.
BenjiMilan
deleted the
feature/gh18_dont_prepend_branch_prefix_if_provided
branch
Closes #18
Don't prepend branch prefix if provided. Sneaky edit on not gitflow init on Init if already inited.