Skip to content

RDKB-62660: Fix pausing device from Xfinity app is not working #193

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
veeraputhiran-thangavel wants to merge 1 commit into
base: develop
Choose a base branch
from
Open

RDKB-62660: Fix pausing device from Xfinity app is not working #193

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion source/firewall/firewall.c
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -8980,7 +8980,7 @@ memset(buf, 0, sizeof(buf));
{
errno = 0;
numDev = strtol(buf, &endptr, 10);
if (endptr == buf || *endptr != '\0' || errno == ERANGE)
if (endptr == buf || (*endptr != '\0' && *endptr != '\n') || errno == ERANGE)
Copy link

Copilot AI Jan 27, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

While this fix correctly solves the immediate issue, it deviates from the established pattern in this codebase for handling newlines after fgets. At line 8474, the codebase explicitly strips the newline character after reading with fgets by checking the length and replacing the newline with a null terminator. Consider refactoring to follow this same pattern for consistency: after line 8982, check if the string ends with a newline and replace it with a null terminator before validation. This would make the validation check simpler and more consistent with the rest of the codebase.

Copilot uses AI. Check for mistakes.
Copy link
Contributor Author

@veeraputhiran-thangavel veeraputhiran-thangavel Jan 28, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@copilot open a new pull request to apply changes based on this feedback

{
FIREWALL_DEBUG("invalid data\n");
break;
Expand Down
Loading