-
Notifications
You must be signed in to change notification settings - Fork 41
RDKB-63378 : Set the stackmode for single build in bootup #202
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
GoutamD2905
wants to merge
28
commits into
develop
Choose a base branch
from
feature/stackmode
base: develop
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from all commits
Commits
Show all changes
28 commits
Select commit
Hold shift + click to select a range
42b8f64
stackmode code
GoutamD2905 a6cc5c5
stackmode code
GoutamD2905 0278668
Updating code
GoutamD2905 69d38e4
Updating code
GoutamD2905 7e42254
updating code
GoutamD2905 e57f2f8
Updating code
GoutamD2905 7dad405
Updating code
GoutamD2905 d59b5a2
Updating code
GoutamD2905 4a7d46d
Updating Code
GoutamD2905 3eb2621
Updating Code
GoutamD2905 bc95e69
Updating Code
GoutamD2905 546aaec
Updating Code
GoutamD2905 fac0d58
Updating Code
GoutamD2905 a3f3e0e
Updating Code
GoutamD2905 e5e55c1
Updating Code
GoutamD2905 eab3b14
Updating code
GoutamD2905 faca7a1
Updating code
GoutamD2905 30b9bad
Updating code
GoutamD2905 e2ea43c
Updating code
GoutamD2905 750c0b8
Updating code
GoutamD2905 3ad98a2
Updating code
GoutamD2905 7e49620
Updating code
GoutamD2905 d505982
Updating code
GoutamD2905 f8727c9
Updating code
GoutamD2905 a1b56fb
Updating code
GoutamD2905 44efa34
Updating code
GoutamD2905 9a6181f
Updating code
GoutamD2905 1c7885e
Updating code
GoutamD2905 File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Some comments aren't visible on the classic Files Changed page.
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The marker file is only deleted in the commercial mode path (line 3547), but there's no deletion attempt in the residential mode path. If the intention is to use the marker file as a persistent indicator, this inconsistency could cause issues. If the marker file should be ephemeral and only used once, the residential path should also attempt to delete it (though it won't exist in that case, the code would be more symmetric). Alternatively, if the marker file is meant to persist, the comment on line 3546 stating "Delete the marker file after successfully setting syscfg" suggests it should be deleted, but this behavior is inconsistent.