Skip to content

RDKB-63406 :Devicetype RFC default value is not migrating after software upgrade #203

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
NareshM1702 wants to merge 10 commits into from
Closed

RDKB-63406 :Devicetype RFC default value is not migrating after software upgrade #203

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
10 commits
Select commit Hold shift + click to select a range
7735aa6
Update utopia_init_xb6.sh
NareshM1702 Jan 30, 2026
f963d29
Update utopia_init_xb6.sh
NareshM1702 Feb 2, 2026
693253a
Update utopia_init_xb6.sh
NareshM1702 Feb 3, 2026
bbf01eb
Update utopia_init_xb6.sh
NareshM1702 Feb 3, 2026
70197ac
Merge branch 'develop' into Devicetype_fix
NareshM1702 Feb 5, 2026
f77a2b3
Rebase (#208)
NareshM1702 Feb 9, 2026
19727fa
Adding devicetype rfc migration logic in utopia_init_hub4.sh
NareshM1702 Feb 9, 2026
499ec83
Rebase (#209)
NareshM1702 Feb 9, 2026
89ef796
Rebase (#210)
NareshM1702 Feb 9, 2026
6f73d2f
Rebase (#211)
NareshM1702 Feb 9, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
14 changes: 10 additions & 4 deletions .github/workflows/native-build.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -19,9 +19,15 @@ jobs:

- name: native build
run: |
chmod +x cov_docker_script/run_setup_dependencies.sh
./cov_docker_script/run_setup_dependencies.sh
chmod +x cov_docker_script/run_native_build.sh
./cov_docker_script/run_native_build.sh
# Trust the workspace
git config --global --add safe.directory '*'
# Pull the latest changes for the native build system
git submodule update --init --recursive --remote
Comment on lines +23 to +25
Copy link

Copilot AI Feb 9, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Setting safe.directory to * disables Git's safety checks globally for all directories in the runner, which is broader than necessary. Restrict this to just the checked-out workspace (e.g., ${{ github.workspace }}) and avoid using --remote for submodules unless you explicitly want non-pinned builds.

Suggested change
git config --global --add safe.directory '*'
# Pull the latest changes for the native build system
git submodule update --init --recursive --remote
git config --global --add safe.directory "${{ github.workspace }}"
# Pull the latest changes for the native build system (use pinned submodule SHAs)
git submodule update --init --recursive

Copilot uses AI. Check for mistakes.
Comment on lines +24 to +25
Copy link

Copilot AI Feb 9, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Using git submodule update --remote makes CI fetch the tip of the configured submodule branch (here develop), which undermines reproducibility and can break builds without any changes in this repo. If you intend to build using the submodule commit pinned in this PR, drop --remote so CI uses the recorded submodule SHA.

Suggested change
# Pull the latest changes for the native build system
git submodule update --init --recursive --remote
# Sync submodules to the commits recorded in this repository
git submodule update --init --recursive

Copilot uses AI. Check for mistakes.
# Build and install dependencies
chmod +x build_tools_workflows/cov_docker_script/setup_dependencies.sh
./build_tools_workflows/cov_docker_script/setup_dependencies.sh ./cov_docker_script/component_config.json
# Build component
chmod +x build_tools_workflows/cov_docker_script/build_native.sh
./build_tools_workflows/cov_docker_script/build_native.sh ./cov_docker_script/component_config.json "$(pwd)"
env:
GITHUB_TOKEN: ${{ secrets.RDKCM_RDKE }}
4 changes: 4 additions & 0 deletions .gitmodules
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,4 @@
[submodule "build_tools_workflows"]
path = build_tools_workflows
url = https://github.com/rdkcentral/build_tools_workflows
branch = develop
1 change: 1 addition & 0 deletions build_tools_workflows
Open in desktop
Submodule build_tools_workflows added at 11f192
1 change: 1 addition & 0 deletions configure.ac
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -95,6 +95,7 @@ AM_CONDITIONAL(CCSP_PLATFORM_BCM, test "x$CCSP_PLATFORM" = xbcm)
AM_CONDITIONAL(CCSP_PLATFORM_INTEL_PUMA7, test "x$CCSP_PLATFORM" = xintel_puma7)
AM_CONDITIONAL([MULTILAN_FEATURE], [test "$MULTILAN_FEATURE" = "yes"])
AM_CONDITIONAL([CPC_FIREWALL_ENABLE], [test "x$CPC_FIREWALL_ENABLE" = "xtrue"])
AM_CONDITIONAL([ONESTACK_PRODUCT_REQ], [test "x$ONESTACK_PRODUCT_REQ" = "xtrue"])
# Checks for header files.
AC_CHECK_HEADERS([stdlib.h string.h unistd.h])

Expand Down
Loading
Loading