RDKEMW-9964: Removing onStopped GDial notification#178
Open
yuvaramachandran-gurusamy wants to merge 4 commits intodevelopfrom
Open
RDKEMW-9964: Removing onStopped GDial notification#178yuvaramachandran-gurusamy wants to merge 4 commits intodevelopfrom
yuvaramachandran-gurusamy wants to merge 4 commits intodevelopfrom
Conversation
Signed-off-by: yuvaramachandran_gurusamy <yuvaramachandran_gurusamy@comcast.com>
Signed-off-by: yuvaramachandran_gurusamy <yuvaramachandran_gurusamy@comcast.com>
Signed-off-by: yuvaramachandran_gurusamy <yuvaramachandran_gurusamy@comcast.com>
Contributor
Coverity Issue - Variable copied when it could be moved"powerState" is passed-by-value as parameter to "std::__cxx11::basic_string<char, std::char_traits, std::allocator >::basic_string(std::__cxx11::basic_string<char, std::char_traits, std::allocator > const &)", when it could be moved instead. Low Impact, CWE-none How to fixUse "std::move(""powerState"")" instead of "powerState". Issue locationThis issue was discovered outside the diff for this Pull Request. You can find it at: |
server/gdialservice.cpp
Outdated
| RequestHandlerPayload payload; | ||
| RequestHandlerPayload payload = {}; | ||
| payload.event = UPDATE_MODEL_NAME; | ||
| payload.model = model; |
Contributor
There was a problem hiding this comment.
Coverity issue no longer present as of: undefined
Show issue
Coverity Issue - Variable copied when it could be moved
"model" is copied in call to copy assignment for class "std::string", when it could be moved instead.
Low Impact, CWE-none
COPY_INSTEAD_OF_MOVE
How to fix
Use "std::move(""model"")" instead of "model".
Signed-off-by: yuvaramachandran_gurusamy <yuvaramachandran_gurusamy@comcast.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
RDKEMW-9964: Removing onStopped GDial notification handling
Signed-off-by: yuvaramachandran_gurusamy [yuvaramachandran_gurusamy@comcast.com]