Update gdial-plat-util.c by agampa263 · Pull Request #184 · rdkcentral/xdialserver

agampa263 · 2026-01-09T11:18:22Z

No description provided.

Copilot

Pull request overview

This pull request modifies a license header comment and updates the CI/CD workflow configuration. However, the license header change introduces a spelling error rather than fixing anything.

Changes:

Introduces a typo in the Apache license header by splitting "under" into "un der"
Updates GitHub Actions workflow to use ubuntu-22.04 runner directly instead of a Docker container

Reviewed changes

Copilot reviewed 1 out of 2 changed files in this pull request and generated 1 comment.

File	Description
server/plat/gdial-plat-util.c	Incorrectly modifies the Apache license header, introducing a spelling error
.github/workflows/native_full_build.yml	Updates CI workflow from containerized build to direct ubuntu-22.04 runner

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Copilot · 2026-01-14T05:31:59Z

server/plat/gdial-plat-util.c

 * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
 * See the License for the specific language governing permissions and
- * limitations under the License.
+ * limitations un der the License.


The word "under" has been incorrectly split into "un der" with an extra space. This should be corrected to maintain the proper Apache license text.

Suggested change

* limitations un der the License.

* limitations under the License.

Copilot

Pull request overview

Copilot reviewed 2 out of 3 changed files in this pull request and generated no new comments.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Copilot

Pull request overview

Copilot reviewed 2 out of 3 changed files in this pull request and generated 1 comment.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Copilot · 2026-01-14T06:20:09Z

server/plat/gdial-plat-util.c

 * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
 * See the License for the specific language governing permissions and
- * limitations under the License.
+ * limitations un der the License.


This change introduces a typo in the Apache License 2.0 header. The text "limitations un der" has an incorrect space splitting "under" into two words. The correct text should be "limitations under the License" as it was before this change.

Suggested change

* limitations un der the License.

* limitations under the License.

Copilot

Pull request overview

Copilot reviewed 2 out of 3 changed files in this pull request and generated 1 comment.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Copilot · 2026-01-14T07:06:19Z

server/plat/gdial-plat-util.c

 * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
 * See the License for the specific language governing permissions and
- * limitations under the License.
+ * limitations un der the License.


Incorrect spacing in the word 'under'. Should be 'under' not 'un der'.

Suggested change

* limitations un der the License.

* limitations under the License.

Copilot

Pull request overview

Copilot reviewed 2 out of 3 changed files in this pull request and generated 3 comments.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Copilot · 2026-01-14T09:05:20Z

build_dependencies.sh

+    -I"$GITHUB_WORKSPACE/stubs" \
+    -I"$INSTALL_DIR/include" \
+    -I"$IARMBUS_PATH/core" \
+    -I"$IARMBUS_PATH/core/include" \


The glib include paths have been removed from the g++ compilation command for libIARMBus.so. The previous version included "-I/usr/include/glib-2.0 -I/usr/lib/x86_64-linux-gnu/glib-2.0/include" which are no longer present. If the IARM headers (libIBus.h or libIARMCore.h) depend on glib types or headers, this compilation will fail. Consider adding these include paths back or using pkg-config to get the proper glib include flags.

Suggested change

-I"$IARMBUS_PATH/core/include" \

-I"$IARMBUS_PATH/core/include" \

$(pkg-config --cflags glib-2.0) \

build_dependencies.sh

Copilot · 2026-01-14T09:05:20Z

build_dependencies.sh

+# Build trower-base64
 if [ ! -d "trower-base64" ]; then
-git clone https://github.com/xmidt-org/trower-base64.git
+    git clone https://github.com/xmidt-org/trower-base64.git


This git clone of https://github.com/xmidt-org/trower-base64.git pulls and builds third-party code from a mutable branch/tag without pinning to an immutable commit or verifying integrity. If the upstream repository or branch is compromised, an attacker-controlled meson.build or source file could execute arbitrary code during meson setup/ninja in your CI or developer environment, potentially with access to secrets and build artifacts. Pin this dependency to a specific commit (or verified release tarball) and, where possible, perform integrity verification before building.

Copilot

Copilot encountered an error and was unable to review this pull request. You can try again by re-requesting a review.

Copilot

Pull request overview

Copilot reviewed 3 out of 4 changed files in this pull request and generated 3 comments.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Copilot · 2026-01-14T11:42:16Z

build_dependencies.sh

+  ninja-build meson cmake curl \
+  libsoup2.4-dev libxml2-dev libglib2.0-dev \
+  gobject-introspection libgirepository1.0-dev \
+  libgtk-3-dev libcunit1-dev valac pandoc


The package libcunit1-dev is newly added but was not present in the original dependency list. If this is an intentional new dependency, ensure it is actually required for the build process. If not required, it should be removed to avoid unnecessary bloat.

Suggested change

libgtk-3-dev libcunit1-dev valac pandoc

libgtk-3-dev valac pandoc

Copilot · 2026-01-14T11:42:16Z

build_dependencies.sh

-fi
+##############################
+# Build trower-base64
+git clone https://github.com/xmidt-org/trower-base64.git || true


Using || true masks clone failures. If the directory already exists, the subsequent cd trower-base64 will succeed but use potentially stale code. Consider checking if the directory exists first, or use git clone with proper error handling to ensure fresh dependencies.

Copilot · 2026-01-14T11:42:17Z

build_dependencies.sh

+git clone https://github.com/rdkcentral/iarmbus.git || true
+export IARMBUS_PATH="$GITHUB_WORKSPACE/iarmbus"

-git clone --branch gssdp-1.2.3 https://gitlab.gnome.org/GNOME/gssdp.git
+git clone --branch R4.4.3 https://github.com/rdkcentral/ThunderTools.git || true
+git clone --branch R4.4.1 https://github.com/rdkcentral/Thunder.git || true
+git clone --branch main https://github.com/rdkcentral/entservices-apis.git || true
+git clone https://$GITHUB_TOKEN@github.com/rdkcentral/entservices-testframework.git || true
+git clone --branch gssdp-1.2.3 https://gitlab.gnome.org/GNOME/gssdp.git || true


All git clone commands use || true which silently ignores failures. This can lead to builds using stale or missing dependencies if clones fail. The original code explicitly removed these directories before cloning. Consider either removing existing directories before cloning or checking for successful clones to ensure build reliability.

Copilot

Pull request overview

Copilot reviewed 3 out of 4 changed files in this pull request and generated no new comments.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Copilot

Pull request overview

Copilot reviewed 3 out of 4 changed files in this pull request and generated 2 comments.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Copilot · 2026-01-15T05:06:36Z

build_dependencies.sh

+# System dependencies (sudo REQUIRED in GitHub Actions)
+sudo apt update
+sudo apt install -y \
+  ninja-build meson cmake curl libcurl4-openssl-dev \


The package 'cmake' is now installed via apt, but this is redundant since the script immediately uses cmake commands. Consider verifying that cmake is available or documenting the minimum required version, as ubuntu-22.04 may have an older cmake version than what was in the previous Docker image.

Copilot · 2026-01-15T05:06:36Z

cov_build.sh

+  -S "$GITHUB_WORKSPACE/server" \
+  -B build/xdialserver \
+  -DCMAKE_INSTALL_PREFIX="$INSTALL_PREFIX" \
+  -DCMAKE_MODULE_PATH="$GITHUB_WORKSPACE/install/tools/cmake" \


The CMAKE_MODULE_PATH references '$GITHUB_WORKSPACE/install/tools/cmake' but this directory is created by the ThunderTools build in build_dependencies.sh. There's an implicit dependency on build_dependencies.sh being run first, which should be documented or validated in the script.

Update gdial-plat-util.c

fa72660

agampa263 requested a review from a team as a code owner January 9, 2026 11:18

Update native_full_build.yml

05aa004

Copilot AI review requested due to automatic review settings January 14, 2026 05:30

Copilot started reviewing on behalf of agampa263 January 14, 2026 05:31 View session

Copilot AI reviewed Jan 14, 2026

View reviewed changes

agampa263 added 2 commits January 14, 2026 11:24

Update native_full_build.yml

252d5b3

Update build_dependencies.sh

9ba446f

Copilot AI review requested due to automatic review settings January 14, 2026 05:57

Update native_full_build.yml

16870c5

Copilot started reviewing on behalf of agampa263 January 14, 2026 05:58 View session

Copilot AI reviewed Jan 14, 2026

View reviewed changes

agampa263 added 2 commits January 14, 2026 11:41

Update build_dependencies.sh

581e87e

Update build_dependencies.sh

01f9586

Copilot AI review requested due to automatic review settings January 14, 2026 06:18

Copilot started reviewing on behalf of agampa263 January 14, 2026 06:18 View session

Copilot AI reviewed Jan 14, 2026

View reviewed changes

agampa263 added 2 commits January 14, 2026 12:04

Update build_dependencies.sh

ed02046

Update build_dependencies.sh

6460dda

Copilot AI review requested due to automatic review settings January 14, 2026 07:04

Copilot started reviewing on behalf of agampa263 January 14, 2026 07:04 View session

Copilot AI reviewed Jan 14, 2026

View reviewed changes

agampa263 added 2 commits January 14, 2026 12:42

Update build_dependencies.sh

4408d1f

Update build_dependencies.sh

03e596e

Copilot AI review requested due to automatic review settings January 14, 2026 08:57

Copilot started reviewing on behalf of agampa263 January 14, 2026 08:58 View session

Copilot AI reviewed Jan 14, 2026

View reviewed changes

agampa263 added 2 commits January 14, 2026 14:44

Update cov_build.sh

d04556e

Update cov_build.sh

e7d9e39

Copilot AI review requested due to automatic review settings January 14, 2026 09:37

Copilot started reviewing on behalf of agampa263 January 14, 2026 09:37 View session

agampa263 added 10 commits January 14, 2026 15:19

Update cov_build.sh

eaed86f

Update cov_build.sh

7ce476c

Update build_dependencies.sh

4802e56

Update cov_build.sh

6d4b9d5

Update cov_build.sh

c269f7e

Update build_dependencies.sh

b87c35b

Update cov_build.sh

33225f8

Update build_dependencies.sh

61f79cb

Update cov_build.sh

bbc259c

Update cov_build.sh

639afb0

Copilot AI reviewed Jan 14, 2026

View reviewed changes

Update cov_build.sh

6abd04c

Copilot AI review requested due to automatic review settings January 14, 2026 11:41

Copilot AI reviewed Jan 14, 2026

View reviewed changes

agampa263 added 2 commits January 14, 2026 17:21

Update cov_build.sh

ab18d4e

Update build_dependencies.sh

7312111

Copilot AI review requested due to automatic review settings January 14, 2026 11:57

Copilot AI reviewed Jan 14, 2026

View reviewed changes

agampa263 added 2 commits January 14, 2026 17:28

Update build_dependencies.sh

6575849

Update cov_build.sh

b18ebba

Copilot AI review requested due to automatic review settings January 15, 2026 05:04

Copilot started reviewing on behalf of agampa263 January 15, 2026 05:04 View session

Copilot AI reviewed Jan 15, 2026

View reviewed changes

	* limitations un der the License.
	* limitations under the License.

	-I"$IARMBUS_PATH/core/include" \
	-I"$IARMBUS_PATH/core/include" \
	$(pkg-config --cflags glib-2.0) \

	libgtk-3-dev libcunit1-dev valac pandoc
	libgtk-3-dev valac pandoc

Conversation

agampa263 commented Jan 9, 2026

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Reviewed changes

Uh oh!

Copilot AI Jan 14, 2026

Choose a reason for hiding this comment

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Uh oh!

Copilot AI Jan 14, 2026

Choose a reason for hiding this comment

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Uh oh!

Copilot AI Jan 14, 2026

Choose a reason for hiding this comment

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Uh oh!

Copilot AI Jan 14, 2026

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Copilot AI Jan 14, 2026

Choose a reason for hiding this comment

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Uh oh!

Copilot AI Jan 14, 2026

Choose a reason for hiding this comment

Uh oh!

Copilot AI Jan 14, 2026

Choose a reason for hiding this comment

Uh oh!

Copilot AI Jan 14, 2026

Choose a reason for hiding this comment

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Uh oh!

Copilot AI Jan 15, 2026

Choose a reason for hiding this comment

Uh oh!

Copilot AI Jan 15, 2026

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

1 participant