Conversation
There was a problem hiding this comment.
Pull request overview
Small touch-up PR that modifies GDial logging and makes a minor markdown-only update to the contributing guide.
Changes:
- Updated
GDialCastObject::applicationStateChangedlogging call ingdial.cpp. - Added a trailing blank line to
CONTRIBUTING.md.
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
server/plat/gdial.cpp |
Alters app state-change logging (currently introduces a format/argument mismatch). |
CONTRIBUTING.md |
Adds a trailing blank line at EOF. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
| @@ -74,7 +74,6 @@ class GDialCastObject | |||
| { | |||
| GDIAL_LOGINFO("AppName[%s] AppID[%s] State[%s] Error[%s]", | |||
| AppObj->appName.c_str(), | |||
There was a problem hiding this comment.
The format string expects 4 %s values (AppName/AppID/State/Error), but only 3 arguments are now passed after removing appId. This will cause incorrect logging and can trigger -Wformat warnings or undefined behavior at runtime. Either add the missing AppObj->appId.c_str() argument back, or remove the AppID placeholder from the format string.
| AppObj->appName.c_str(), | |
| AppObj->appName.c_str(), | |
| AppObj->appId.c_str(), |
| @@ -74,7 +74,6 @@ class GDialCastObject | |||
| { | |||
| GDIAL_LOGINFO("AppName[%s] AppID[%s] State[%s] Error[%s]", | |||
There was a problem hiding this comment.
Coverity Issue - Missing argument to printf format specifier
No argument for format specifier "%s".
Medium Impact, CWE-685
PRINTF_ARGS
2 participants
No description provided.