Skip to content

Omit properties without values in StandardEntity, StandardRelation and ClassicEntity #103

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
AlexeyMz merged 1 commit into from
Nov 15, 2025
Merged

Omit properties without values in StandardEntity, StandardRelation and ClassicEntity #103

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions CHANGELOG.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,6 +6,7 @@ The format is based on [Keep a Changelog](http://keepachangelog.com/) and this p
## [Unreleased]
#### 🐛 Fixed
- Fix incorrect canvas viewport position when `zoomToFit()` or similar operation is called immediately after element position changes;
- Omit properties without values in `StandardEntity`, `StandardRelation` and `ClassicEntity`.

## [0.31.0] - 2025-11-15
#### 🚀 New Features
Expand Down
11 changes: 10 additions & 1 deletion src/templates/classicTemplate.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -146,7 +146,16 @@ function PropertyList(props: {
const {data} = props;
const {model, translation: t} = useWorkspace();

const propertyIris: PropertyTypeIri[] = Object.keys(data.properties);
const propertyIris: PropertyTypeIri[] = [];
for (const iri in data.properties) {
if (
Object.prototype.hasOwnProperty.call(data.properties, iri) &&
data.properties[iri].length > 0
) {
propertyIris.push(iri);
}
}

useKeyedSyncStore(subscribePropertyTypes, propertyIris, model);

const properties = propertyIris.map(iri => {
Expand Down
12 changes: 9 additions & 3 deletions src/templates/standardElement.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -462,9 +462,15 @@ function PropertyList(props: {
const {data, shouldInclude} = props;
const {model, translation: t} = useWorkspace();

let propertyIris: PropertyTypeIri[] = Object.keys(data.properties);
if (shouldInclude) {
propertyIris = propertyIris.filter(shouldInclude);
const propertyIris: PropertyTypeIri[] = [];
for (const iri in data.properties) {
if (
Object.prototype.hasOwnProperty.call(data.properties, iri) &&
data.properties[iri].length > 0 &&
(!shouldInclude || shouldInclude(iri))
) {
propertyIris.push(iri);
}
}

useKeyedSyncStore(subscribePropertyTypes, propertyIris, model);
Expand Down
11 changes: 10 additions & 1 deletion src/templates/standardLink.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -235,7 +235,16 @@ function LinkProperties(props: StandardRelationProps) {
const {model, translation: t} = useWorkspace();
const {data} = link as RelationLink;

const propertyIris: PropertyTypeIri[] = Object.keys(data.properties);
const propertyIris: PropertyTypeIri[] = [];
for (const iri in data.properties) {
if (
Object.prototype.hasOwnProperty.call(data.properties, iri) &&
data.properties[iri].length > 0
) {
propertyIris.push(iri);
}
}

useKeyedSyncStore(subscribePropertyTypes, propertyIris, model);

const properties = propertyIris.map(iri => {
Expand Down