Minor documentation improvements for references to deprecated Factory#241
Merged
WyriHaximus merged 1 commit intoreactphp:masterfrom Nov 13, 2021
Merged
Minor documentation improvements for references to deprecated Factory#241WyriHaximus merged 1 commit intoreactphp:masterfrom
Factory#241WyriHaximus merged 1 commit intoreactphp:masterfrom
Conversation
SimonFrings
requested changes
Oct 20, 2021
dbu
commented
Oct 20, 2021
Contributor
Author
|
no problems, stumbled over it when somebody changed what we do in php-http/react-adapter i accepted your changes and fixed a spelling error i noticed. |
Member
|
Thx for the update 👍. The only thing I have to note is that I don't think it's necessary to have three commits for these changes, maybe you could squash these three together? |
Contributor
Author
|
of course. just squashed the commits |
Member
|
Looks good, nice work 👍 |
SimonFrings
approved these changes
Oct 21, 2021
clue
reviewed
Oct 21, 2021
Member
clue
left a comment
clue
left a comment
There was a problem hiding this comment.
@dbu Thank you for spotting and filing this PR, the suggested changes look good to me! 👍
The same text is also used in the referenced classes (also note the maximum line length). May I ask you to amend your changes to keep this in sync?
the readme should not recommend to use the factory anymore but Loop::create Co-authored-by: Simon Frings <simon.frings1@web.de>
Contributor
Author
|
i adjusted the phpdoc accordingly and made the lines shorter. |
clue
changed the title
Factory
WyriHaximus
approved these changes
Nov 13, 2021
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
the readme should not recommend to use the factory anymore but Loop::create