Use native PHP indexing for child process file descriptors#56
Conversation
WyriHaximus
approved these changes
Jan 14, 2019
jsor
approved these changes
Jan 14, 2019
clue
approved these changes
Jan 17, 2019
Member
clue
left a comment
clue
left a comment
There was a problem hiding this comment.
@CharlotteDunois Thank you for the updated version, much appreciated, now let's get this in! 
ghost
deleted the
ghost
mentioned this pull request
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR is a replacement for #53. As suggested by @clue, we just append to the array and let PHP handle assigning the key.
This PR fixes clashing file descriptors (and therefore overwriting each other) when using the child process adapter.