Fix optional test for ENETUNREACH error condition#288
Merged
WyriHaximus merged 1 commit intoreactphp:1.xfrom Apr 2, 2022
Merged
Fix optional test for ENETUNREACH error condition#288WyriHaximus merged 1 commit intoreactphp:1.xfrom
ENETUNREACH error condition#288WyriHaximus merged 1 commit intoreactphp:1.xfrom
Conversation
SimonFrings
approved these changes
Mar 22, 2022
Member
Author
|
For the reference: Given that this test is skipped on most platforms anyway, I've reduced the time it takes to skip from ~20s to ~2s. The total test time is now down from ~23s to ~5s. |
WyriHaximus
approved these changes
Apr 2, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This minor changeset fixes the optional test for the
ENETUNREACHerror condition. This test is skipped on many platforms and as such also wasn't executed/spotted on GitHub Actions. It looks like this minor test issue has been introduced via #283. Originally introduced via #265. Spotted while working on reactphp/reactphp#454