Fix legacy HHVM build by downgrading Composer#289
Merged
WyriHaximus merged 1 commit intoreactphp:1.xfrom Apr 9, 2022
Merged
Conversation
Member
|
We have 0.0% users on HHVM, how about we drop support for it? https://packagist.org/packages/react/socket/php-stats#all |
Member
Author
@WyriHaximus Dropping legacy HHVM is definitely an option as suggested in my OP. However, I would argue that dropping legacy HHVM actually requires more work at this point to avoid any unneeded leftovers. Given this changeset contains only a single line, my vote would be merge this as is and then look into this in a concentrated effort in the (possibly not too far) future 👍 |
WyriHaximus
approved these changes
Apr 9, 2022
Member
@clue 👍 |
This was referenced Apr 11, 2022
This was referenced Apr 26, 2022
This was referenced May 9, 2022
This was referenced Jun 22, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This changeset fixes the legacy HHVM build by downgrading Composer. Composer 2.3 does not longer support legacy PHP or legacy HHVM, so we have to downgrade to Composer LTS in order to run our test suite.
I'm filing this as an RFC to see if we want to apply this change to all our components (all HHVM builds currently fail). I'm not going to argue there's a lot of value in supporting a legacy HHVM build that accounts for less than 0.1% of our installation base, but at this point fixing legacy support is actually easier than dropping it entirely. At the same time, this is not the first fix for HHVM: https://github.com/reactphp/socket/pulls?q=hhvm
As much as I dislike having to address this, my vote would probably be to merge this as is and look into dropping legacy environments in a concentrated effort not too far in the future. WDYT?