bump sdk50 #144
bump sdk50 #144
Conversation
trinitys7
force-pushed
the
bump_sdk_v50
branch
from
921f404 to
c19b60f
Compare
|
@vietanh2k all lint errors must be fixed |
|
@catShaark @sontrinh16 |
yep, both still uses Bech32Codec so still the same |
| multiStakerAddr, valAcc, err := types.AccAddrAndValAddrFromStrings(msg.DelegatorAddress, msg.ValidatorAddress) | ||
| func (k msgServer) CreateValidator(ctx context.Context, msg *stakingtypes.MsgCreateValidator) (*stakingtypes.MsgCreateValidatorResponse, error) { | ||
| sdkCtx := sdk.UnwrapSDKContext(ctx) | ||
| multiStakerAddr, valAcc, err := types.ValidatorAccAddrAndValAddrFromStrings(msg.ValidatorAddress) |
There was a problem hiding this comment.
This is false, validator address is not multi staker address, validator and delegator have different address' prefix and we don't need to create new function to generate validator address.
There was a problem hiding this comment.
I've re-read sdk50, it still work, but I think we should add address codec and validator codec for transparent this logic
| return valUpdates, nil | ||
| } | ||
|
|
||
| func (am AppModule) StakingAppModule() staking.AppModule { |
There was a problem hiding this comment.
Why do we need this function?
5 participants
No description provided.