Skip to content

Improvement: Handle zero_shares dual to slashing/rounding #155

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
jiujiteiro merged 4 commits into from
Sep 29, 2025
Merged

Improvement: Handle zero_shares dual to slashing/rounding #155

jiujiteiro merged 4 commits into from
Sep 29, 2025

Conversation

@hieuvubk
Copy link
Contributor

@hieuvubk hieuvubk commented Sep 26, 2025

  • Zero shares:
    • Tokens lock but zero shares remain so we could not undelegate theirs delegations => Undelegate fail
    • Delete lock entry and burn corresponding amount to fix this edge case

@hieuvubk hieuvubk mentioned this pull request Sep 26, 2025
Merged
@jiujiteiro jiujiteiro merged commit 9dcddd7 into main Sep 29, 2025
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@jiujiteiro jiujiteiro jiujiteiro approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@hieuvubk @jiujiteiro