-
Notifications
You must be signed in to change notification settings - Fork 4
feat: Flux integration #154
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
andrewbabbittdev
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Almost there
…to flux-installer. medulla chart now only has objects for medulla
|
PR is ready for review. |
| documentation: | ||
| replicaCount: 1 | ||
| image: | ||
| repository: documentation |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks like were missing the registry values here, meaning this is pulling from docker hub correct? This wont work if we plan on releasing Iron Bank images / GHCR.
Containers are broken down into a few sections:
Registry: ghcr.io
Repository: recro/medulla
Image: documentation
Tag: 0.1.0
Full URL: ghcr.io/recro/medulla/documentation:0.1.0
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you for the input. I will work on adding this.
deploy/flux-installer/templates/apps/istio/istio-base-repo.yaml
Outdated
Show resolved
Hide resolved
deploy/medulla/templates/vs.yaml
Outdated
| @@ -0,0 +1,18 @@ | |||
| --- | |||
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Dont believe we need this if were using the istio ingress class no? You can either use Virtual Services + Gateways or the Istio Ingress Class but not both.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
If the VS and gateway are not needed then that will allow us to use only one helm chart. Do you want me to move forward with that?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
VS and Gateways have more features than an Ingress, so I would prefer we just use the Istio Gateway and VS's but there does need to be a VS for all services that are to be exposed.
You will still need two charts to support other dependencies being deploy (ex. TiDB cluster)
…ecko/medulla into junderwood/flux-integration
Flux Integration With Medulla Chart
Summary of the changes
Integrated flux into the medulla chart.
Description
helm install will launch medulla chart along with the following dependancies:
Fixes #99