Skip to content

Conversation

@Slygecko
Copy link

Flux Integration With Medulla Chart

  • You've read the Contributor Guide and Code of Conduct.
  • You've included unit or integration tests for your change, where applicable.
  • You've included inline docs for your change, where applicable.
  • There's an open issue for the PR that you are making. If you'd like to propose a new feature or change, please open an issue to discuss the change or find an existing issue.

Summary of the changes

Integrated flux into the medulla chart.

Description

helm install will launch medulla chart along with the following dependancies:

  • flux
  • Istio
  • tidb
  • dapr
  • gitea

Fixes #99

@Slygecko Slygecko changed the title Junderwood/flux integration feat: Junderwood/flux integration Jun 16, 2022
@andrewbabbittdev andrewbabbittdev changed the title feat: Junderwood/flux integration feat: flux integration Jun 17, 2022
@andrewbabbittdev andrewbabbittdev changed the title feat: flux integration feat: Flux integration Jun 17, 2022
Copy link
Member

@andrewbabbittdev andrewbabbittdev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Almost there

@Slygecko
Copy link
Author

PR is ready for review.

documentation:
replicaCount: 1
image:
repository: documentation
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks like were missing the registry values here, meaning this is pulling from docker hub correct? This wont work if we plan on releasing Iron Bank images / GHCR.

Containers are broken down into a few sections:

Registry: ghcr.io
Repository: recro/medulla
Image: documentation
Tag: 0.1.0

Full URL: ghcr.io/recro/medulla/documentation:0.1.0

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for the input. I will work on adding this.

@@ -0,0 +1,18 @@
---
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Dont believe we need this if were using the istio ingress class no? You can either use Virtual Services + Gateways or the Istio Ingress Class but not both.

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If the VS and gateway are not needed then that will allow us to use only one helm chart. Do you want me to move forward with that?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

VS and Gateways have more features than an Ingress, so I would prefer we just use the Istio Gateway and VS's but there does need to be a VS for all services that are to be exposed.

You will still need two charts to support other dependencies being deploy (ex. TiDB cluster)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Kubernetes Helm Chart

2 participants