-
Notifications
You must be signed in to change notification settings - Fork 0
Increase PHPStan level to 6 #7
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
5707477 to
3847ab0
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
This PR increases the PHPStan static analysis level from 5 to 6, which requires more strict type annotations and removes type inference for certain scenarios. The changes primarily focus on adding proper type hints, parameter and return type annotations, and detailed PHPDoc comments throughout the codebase to satisfy the stricter analysis requirements.
Key changes include:
- Added comprehensive type annotations to method parameters and return types
- Enhanced PHPDoc comments with detailed array shapes and generic types
- Fixed type-related issues identified by the higher PHPStan level
- Added proper type assertions and null checks for better type safety
Reviewed Changes
Copilot reviewed 71 out of 71 changed files in this pull request and generated 3 comments.
Show a summary per file
| File | Description |
|---|---|
| phpstan.neon | Updated PHPStan level from 5 to 6 and added configuration for stricter analysis |
| Multiple test files | Added type hints to closures, method parameters, and enhanced PHPDoc annotations |
| Multiple source files | Added comprehensive type annotations, return types, and detailed array shape documentation |
| src/Recruiter/functions.php | Enhanced array_group_by function with proper generics and type safety |
| src/Recruiter/Infrastructure/Command/OptionTools.php | New utility trait for type-safe option handling |
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
3847ab0 to
2879fc4
Compare
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
a36bbfa to
e6b128e
Compare
e6b128e to
4dc4e2d
Compare
6452923 to
a1c04bc
Compare
This is the highest level before everything stops working (still figuring out why)