Skip to content

[CodeQuality] Skip loose compare float vs integer on AssertEqualsToSameRector#430

Merged
samsonasik merged 5 commits intomainfrom
skip-loose
Dec 25, 2024
Merged

[CodeQuality] Skip loose compare float vs integer on AssertEqualsToSameRector#430
samsonasik merged 5 commits intomainfrom
skip-loose

Conversation

@samsonasik
Copy link
Member

The following should be skipped:

$this->assertEquals(1.0, 1);

as cause error on assertSame().

@samsonasik samsonasik marked this pull request as draft December 25, 2024 09:59
@samsonasik
Copy link
Member Author

Ok, comparing array or bool to non-bool should not happen on test, but float/integer to integer/float may happen.

This patch only skip:

  • compare float to integer
  • composer integer to float
  • composer float to mixed
  • composer integer to mixed

@samsonasik samsonasik closed this Dec 25, 2024
@samsonasik samsonasik reopened this Dec 25, 2024
@samsonasik samsonasik marked this pull request as ready for review December 25, 2024 10:31
@samsonasik
Copy link
Member Author

All checks have passed 🎉 @TomasVotruba I am merging it to have faster feedback to test ;)

@samsonasik samsonasik merged commit a4a69ed into main Dec 25, 2024
6 checks passed
@samsonasik samsonasik deleted the skip-loose branch December 25, 2024 10:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants